Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: webkit/port/platform/chromium/RenderThemeGtk.cpp

Issue 9757: Cache the GdkSkia object in PlatformContextSkia so that we aren't creating (Closed)
Patch Set: Moving files against Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/SConscript.port ('k') | webkit/port/platform/chromium/gdkskiadrawable.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/port/platform/chromium/RenderThemeGtk.cpp
diff --git a/webkit/port/platform/chromium/RenderThemeGtk.cpp b/webkit/port/platform/chromium/RenderThemeGtk.cpp
index 54b3254f0c0b80e752248e1e2717f49abc0b4a68..9d2f2cd20d5fce8546360ad3455f03c4563ba7f7 100644
--- a/webkit/port/platform/chromium/RenderThemeGtk.cpp
+++ b/webkit/port/platform/chromium/RenderThemeGtk.cpp
@@ -29,7 +29,7 @@
#include "PlatformContextSkia.h"
#include "RenderObject.h"
#include "gtkdrawing.h"
-#include "gdkskiadrawable.h"
+#include "GdkSkia.h"
#include <gdk/gdk.h>
@@ -183,13 +183,9 @@ static bool paintMozWidget(RenderTheme* theme, GtkThemeWidgetType type, RenderOb
gdk_rectangle_intersect(&gdkRect, &gdkClipRect, &gdkClipRect);
- // TODO(agl): we should look at not creating this anew every time.
- GdkSkia* skiadrawable = gdk_skia_new(canvas);
-
const gint r =
- moz_gtk_widget_paint(type, skiadrawable, &gdkRect, &gdkClipRect, &mozState, flags, direction) != MOZ_GTK_SUCCESS;
+ moz_gtk_widget_paint(type, pcs->gdk_skia(), &gdkRect, &gdkClipRect, &mozState, flags, direction) != MOZ_GTK_SUCCESS;
- g_object_unref(skiadrawable);
return r;
}
« no previous file with comments | « webkit/SConscript.port ('k') | webkit/port/platform/chromium/gdkskiadrawable.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698