Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 9757: Cache the GdkSkia object in PlatformContextSkia so that we aren't creating (Closed)

Created:
12 years, 1 month ago by agl
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Cache the GdkSkia object in PlatformContextSkia so that we aren't creating and deleting them for every widget drawn.

Patch Set 1 #

Patch Set 2 : Addressing comments #

Patch Set 3 : Stupid star #

Patch Set 4 : Try and fail to get upload.py to see the rename #

Patch Set 5 : Moving files against #

Unified diffs Side-by-side diffs Delta from patch set Stats (+612 lines, -593 lines) Patch
M base/gfx/platform_canvas_linux.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/SConscript View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/SConscript.port View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/port/platform/chromium/RenderThemeGtk.cpp View 1 2 chunks +2 lines, -6 lines 0 comments Download
M webkit/port/platform/chromium/gdkskiadrawable.h View 1 chunk +0 lines, -74 lines 0 comments Download
M webkit/port/platform/chromium/gdkskiadrawable.cc View 1 chunk +0 lines, -508 lines 0 comments Download
M webkit/port/platform/graphics/PlatformContextSkia.h View 1 2 3 chunks +11 lines, -0 lines 0 comments Download
M webkit/port/platform/graphics/PlatformContextSkia.cpp View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
A webkit/port/platform/graphics/skia/GdkSkia.h View 1 chunk +74 lines, -0 lines 0 comments Download
A webkit/port/platform/graphics/skia/GdkSkia.cc View 1 chunk +508 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
agl
I ended up keeping it in webkit/port and adding the cache in PlatformContextSkia instead. This ...
12 years, 1 month ago (2008-11-11 00:00:08 UTC) #1
Evan Martin
http://codereview.chromium.org/9757/diff/1/3 File webkit/SConscript.port (right): http://codereview.chromium.org/9757/diff/1/3#newcode131 Line 131: '$PORT_DIR/platform/graphics/gdk_skia.cc', alphabetize ? Should the file have a ...
12 years, 1 month ago (2008-11-11 00:04:52 UTC) #2
agl
http://codereview.chromium.org/9757/diff/1/3 File webkit/SConscript.port (right): http://codereview.chromium.org/9757/diff/1/3#newcode131 Line 131: '$PORT_DIR/platform/graphics/gdk_skia.cc', On 2008/11/11 00:04:52, Evan Martin wrote: > ...
12 years, 1 month ago (2008-11-11 00:13:23 UTC) #3
agl
http://codereview.chromium.org/9757/diff/1/8 File webkit/port/platform/graphics/PlatformContextSkia.h (right): http://codereview.chromium.org/9757/diff/1/8#newcode169 Line 169: GdkSkia *m_gdkskia; On 2008/11/11 00:04:52, Evan Martin wrote: ...
12 years, 1 month ago (2008-11-11 00:14:43 UTC) #4
Evan Martin
12 years, 1 month ago (2008-11-11 00:19:58 UTC) #5
LGTM

http://codereview.chromium.org/9757/diff/27/212
File webkit/SConscript.port (right):

http://codereview.chromium.org/9757/diff/27/212#newcode131
Line 131: '$PORT_DIR/platform/graphics/GdkSkia.cc',
alphabetize

Powered by Google App Engine
This is Rietveld 408576698