Issue 9756001: Allow 'class Singleton<T>' in header files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9756001: Allow 'class Singleton<T>' in header files. (Closed)

Created:
8 years, 9 months ago by Bernhard Bauer

Modified:
8 years, 9 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Allow 'class Singleton<T>' in header files. BUG=none TEST='friend class Singleton<T>' is allowed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127751

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -5 lines)			Patch
	M	presubmit_canned_checks.py	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
	M	tests/presubmit_unittest.py	View	1	2 chunks	+36 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

Bernhard Bauer

On 2012/03/20 12:39:08, Marc-Antoine Ruel wrote: > Please add a unit test, then it's fine ...

8 years, 9 months ago (2012-03-20 18:00:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/9756001/4001

8 years, 9 months ago (2012-03-20 19:42:15 UTC) #5

Change committed as 127751