Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 9754005: Change json_reader_unittest.cc to use less ASSERT macros and more EXPECT ones. (Closed)

Created:
8 years, 9 months ago by Robert Sesek
Modified:
8 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Change json_reader_unittest.cc to use less ASSERT macros and more EXPECT ones. This is in preparation for making a change to the JSONReader and it makes verifying the change easier. BUG=111581 TEST=base_unittests --gtest_filter=JSON\* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127812

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -126 lines) Patch
M base/json/json_reader_unittest.cc View 10 chunks +127 lines, -126 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
This leaves in place ASSERTs for when the value being checked could be NULL-derefed afterwards. ...
8 years, 9 months ago (2012-03-20 20:47:10 UTC) #1
Mark Mentovai
LGTM
8 years, 9 months ago (2012-03-20 20:52:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/9754005/1
8 years, 9 months ago (2012-03-20 20:52:37 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-20 22:21:53 UTC) #4
Change committed as 127812

Powered by Google App Engine
This is Rietveld 408576698