Issue 9752: Added CreateTemporaryFileName that takes a FilePath argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9752: Added CreateTemporaryFileName that takes a FilePath argument. (Closed)

Created:
12 years, 1 month ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Added CreateTemporaryFileName that takes a FilePath argument. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5142

Patch Set 3 : '' #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -18 lines)			Patch
M	base/file_util.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	base/file_util.cc	View		1 chunk	+7 lines, -0 lines	1 comment	Download
M	base/file_util_posix.cc	View	1	3 chunks	+12 lines, -11 lines	0 comments	Download
M	base/file_util_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/file_util_win.cc	View	1	1 chunk	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

http://codereview.chromium.org/9752/diff/1/2 File base/file_util_win.cc (right): http://codereview.chromium.org/9752/diff/1/2#newcode410 Line 410: bool CreateTemporaryFileName(std::wstring* temp_file) { Rather than defining this ...

12 years, 1 month ago (2008-11-10 22:56:22 UTC) #2

Evan Stade

12 years, 1 month ago (2008-11-10 23:37:15 UTC) #3

Evan Martin

12 years, 1 month ago (2008-11-10 23:45:35 UTC) #4

LGTM

http://codereview.chromium.org/9752/diff/11/16
File base/file_util.cc (right):

http://codereview.chromium.org/9752/diff/11/16#newcode348
Line 348: if(!CreateTemporaryFileName(&temp_file_path))
space after if

Expand Messages | Collapse Messages

Issue 9752: Added CreateTemporaryFileName that takes a FilePath argument. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages