[Sync] Have SyncableService's take ownership of their SyncChangeProcessor.

chrome/browser/extensions/settings/settings_apitest.cc

Index: chrome/browser/extensions/settings/settings_apitest.cc
diff --git a/chrome/browser/extensions/settings/settings_apitest.cc b/chrome/browser/extensions/settings/settings_apitest.cc
index c5990cc03cfc83501d98df3ab39a07fcf2f5ac0a..25730367a0c18bba430a78b9b19b4c6c827a7063 100644
--- a/chrome/browser/extensions/settings/settings_apitest.cc
+++ b/chrome/browser/extensions/settings/settings_apitest.cc
@@ -42,6 +42,26 @@ class NoopSyncChangeProcessor : public SyncChangeProcessor {
   virtual ~NoopSyncChangeProcessor() {};
 };
 
+class SyncChangeProcessorDelegate : public SyncChangeProcessor {

[asargent_no_longer_on_chrome, 2012/03/22 22:54:11]

This looks like duplicate code from the version in
app_notification_manager_sync_unittest.cc - can we put it in it's own standalone
.h/cc file somewhere so we can share the code?

[Nicolas Zea, 2012/03/22 23:05:29]

That will be arriving as part of a follow-up patch (along with pulling the
various implementations of the above NoopSyncChangeProcessor out into a single
class as well).

[asargent_no_longer_on_chrome, 2012/03/22 23:14:24]

Ok, glad to hear it.

+ public:
+  explicit SyncChangeProcessorDelegate(SyncChangeProcessor* recipient)
+      : recipient_(recipient) {
+    DCHECK(recipient_);
+  }
+  virtual ~SyncChangeProcessorDelegate() {}
+
+  // SyncChangeProcessor implementation.
+  virtual SyncError ProcessSyncChanges(
+      const tracked_objects::Location& from_here,
+      const SyncChangeList& change_list) OVERRIDE {
+    return recipient_->ProcessSyncChanges(from_here, change_list);
+  }
+
+ private:
+  // The recipient of all sync changes.
+  SyncChangeProcessor* recipient_;
+};
+
 }  // namespace
 
 class ExtensionSettingsApiTest : public ExtensionApiTest {
@@ -139,7 +159,8 @@ class ExtensionSettingsApiTest : public ExtensionApiTest {
     EXPECT_FALSE(settings_service->MergeDataAndStartSyncing(
         kModelType,
         SyncDataList(),
-        sync_processor).IsSet());
+        scoped_ptr<SyncChangeProcessor>(
+            new SyncChangeProcessorDelegate(sync_processor))).IsSet());
   }
 
   void SendChangesToSyncableService(