chrome/browser/sync/api/syncable_service.h - Issue 9749012: [Sync] Have SyncableService's take ownership of their SyncChangeProcessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/api/syncable_service.h

Issue 9749012: [Sync] Have SyncableService's take ownership of their SyncChangeProcessor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Initial comments Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/search_engines/template_url_service_sync_unittest.cc ('K') | « chrome/browser/sync/api/fake_syncable_service.cc ('k') | chrome/browser/sync/api/syncable_service_mock.h » ('j') | chrome/browser/sync/glue/ui_data_type_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/api/syncable_service.h

diff --git a/chrome/browser/sync/api/syncable_service.h b/chrome/browser/sync/api/syncable_service.h

index 6b5152bdeca04e3d49ba39337e48af2e4a528d25..8e8eba75fddad5f85d884d27799752533872d095 100644

--- a/chrome/browser/sync/api/syncable_service.h

+++ b/chrome/browser/sync/api/syncable_service.h

@@ -9,6 +9,7 @@

#include <vector>

#include "base/compiler_specific.h"

+#include "base/memory/scoped_ptr.h"

#include "base/memory/weak_ptr.h"

#include "chrome/browser/sync/api/sync_change_processor.h"

#include "chrome/browser/sync/api/sync_data.h"

@@ -37,7 +38,7 @@ class SyncableService : public SyncChangeProcessor,

virtual SyncError MergeDataAndStartSyncing(

syncable::ModelType type,

const SyncDataList& initial_sync_data,

- SyncChangeProcessor* sync_processor) = 0;

+ scoped_ptr<SyncChangeProcessor> sync_processor) = 0;

// Stop syncing the specified type and reset state.

virtual void StopSyncing(syncable::ModelType type) = 0;