chrome/browser/prefs/pref_model_associator.h - Issue 9749012: [Sync] Have SyncableService's take ownership of their SyncChangeProcessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/pref_model_associator.h

Issue 9749012: [Sync] Have SyncableService's take ownership of their SyncChangeProcessor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Initial comments Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/test_extension_service.cc ('k') | chrome/browser/prefs/pref_model_associator.cc » ('j') | chrome/browser/prefs/pref_model_associator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prefs/pref_model_associator.h

diff --git a/chrome/browser/prefs/pref_model_associator.h b/chrome/browser/prefs/pref_model_associator.h

index 3d2fd1f23d20d982461b40693507dc9994dc46f1..c09821510a93c9b76052cddd45824ed5f86c5ca0 100644

--- a/chrome/browser/prefs/pref_model_associator.h

+++ b/chrome/browser/prefs/pref_model_associator.h

@@ -43,7 +43,7 @@ class PrefModelAssociator

virtual SyncError MergeDataAndStartSyncing(

syncable::ModelType type,

const SyncDataList& initial_sync_data,

- SyncChangeProcessor* sync_processor) OVERRIDE;

+ scoped_ptr<SyncChangeProcessor> sync_processor) OVERRIDE;

virtual void StopSyncing(syncable::ModelType type) OVERRIDE;

// Returns the list of preference names that are registered as syncable, and

@@ -141,7 +141,7 @@ class PrefModelAssociator

PrefService* pref_service_;

// Sync's SyncChange handler. We push all our changes through this.

- SyncChangeProcessor* sync_processor_;

+ scoped_ptr<SyncChangeProcessor> sync_processor_;

DISALLOW_COPY_AND_ASSIGN(PrefModelAssociator);

};