Fix memory leak when errors happens in NaClProcessHost::Launch. Allow Launch to

chrome/browser/nacl_host/nacl_process_host.h

Index: chrome/browser/nacl_host/nacl_process_host.h
===================================================================
--- chrome/browser/nacl_host/nacl_process_host.h	(revision 127497)
+++ chrome/browser/nacl_host/nacl_process_host.h	(working copy)
@@ -41,7 +41,7 @@
   // the NaCl process host will assume responsibility for sending the reply
   // message. On failure, the reply will not be sent and this is the caller's
   // responsibility to avoid hanging the renderer.
-  bool Launch(ChromeRenderMessageFilter* chrome_render_message_filter,
+  void Launch(ChromeRenderMessageFilter* chrome_render_message_filter,
               int socket_count,
               IPC::Message* reply_msg);
 
@@ -69,6 +69,9 @@
   void IrtReady();
   void SendStart(base::PlatformFile irt_file);
 
+  // Send message to the renderer that NaCl failed to load.
+  void SendNaClLaunchError();
+
   bool IsHardwareExceptionHandlingEnabled();
 
  private:
@@ -76,6 +79,10 @@
   class DebugContext;
 
   scoped_refptr<DebugContext> debug_context_;
+
+  // This field becames true when the broker successfully launched

[Mark Seaborn, 2012/03/21 20:41:29]

'becomes'.  Actually the comment is rather unnecessary since the variable name
is descriptive enough.

[halyavin, 2012/03/22 08:35:47]

Done.

+  // the NaCl loader.
+  bool process_launched_by_broker_;
 #endif
   // The ChromeRenderMessageFilter that requested this NaCl process.  We use
   // this for sending the reply once the process has started.