Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1725)

Unified Diff: chrome/browser/renderer_host/chrome_render_message_filter.cc

Issue 9748012: Fix memory leak when errors happens in NaClProcessHost::Launch. Allow Launch to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/nacl_host/nacl_process_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/chrome_render_message_filter.cc
===================================================================
--- chrome/browser/renderer_host/chrome_render_message_filter.cc (revision 127497)
+++ chrome/browser/renderer_host/chrome_render_message_filter.cc (working copy)
@@ -156,12 +156,7 @@
void ChromeRenderMessageFilter::OnLaunchNaCl(
const std::wstring& url, int socket_count, IPC::Message* reply_msg) {
NaClProcessHost* host = new NaClProcessHost(url);
- if (!host->Launch(this, socket_count, reply_msg)) {
- // On failure, the NaClProcessHost didn't send the reply which the renderer
- // is blocked on. Unblock the renderer by sending an error.
- reply_msg->set_reply_error();
- Send(reply_msg);
- }
+ host->Launch(this, socket_count, reply_msg);
}
#endif
« no previous file with comments | « chrome/browser/nacl_host/nacl_process_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698