Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: chrome/browser/nacl_host/nacl_process_host.h

Issue 9748012: Fix memory leak when errors happens in NaClProcessHost::Launch. Allow Launch to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/nacl_host/nacl_process_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/nacl_host/nacl_process_host.h
===================================================================
--- chrome/browser/nacl_host/nacl_process_host.h (revision 127497)
+++ chrome/browser/nacl_host/nacl_process_host.h (working copy)
@@ -37,11 +37,9 @@
// Do any minimal work that must be done at browser startup.
static void EarlyStartup();
- // Initialize the new NaCl process, returning true on success. On success,
- // the NaCl process host will assume responsibility for sending the reply
- // message. On failure, the reply will not be sent and this is the caller's
- // responsibility to avoid hanging the renderer.
- bool Launch(ChromeRenderMessageFilter* chrome_render_message_filter,
+ // Initialize the new NaCl process. Result is returned by sending ipc
+ // message reply_msg.
+ void Launch(ChromeRenderMessageFilter* chrome_render_message_filter,
int socket_count,
IPC::Message* reply_msg);
@@ -76,6 +74,10 @@
class DebugContext;
scoped_refptr<DebugContext> debug_context_;
+
+ // This field becomes true when the broker successfully launched
+ // the NaCl loader.
+ bool process_launched_by_broker_;
#endif
// The ChromeRenderMessageFilter that requested this NaCl process. We use
// this for sending the reply once the process has started.
« no previous file with comments | « no previous file | chrome/browser/nacl_host/nacl_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698