Wired GDataFileSystem::GetFile() method with internal cache.

chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <errno.h>
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 141 matching lines @@
     GURL unused;
     return file_system_->UpdateDirectoryWithDocumentFeed(
         list, FROM_SERVER) == base::PLATFORM_FILE_OK;
   }
 
   bool RemoveFile(const FilePath& file_path) {
     return file_system_->RemoveFileFromFileSystem(file_path) ==
         base::PLATFORM_FILE_OK;
   }
 
+  FilePath GetCachePathForFile(GDataFile* file) {
+    return file_system_->GetCacheFilePath(file->resource_id(),
+                                          file->file_md5(),
+                                          GDataFileSystem::CACHE_TYPE_TMP,
+                                          false);
+  }
+
   GDataFileBase* FindFile(const FilePath& file_path) {
     ReadOnlyFindFileDelegate search_delegate;
     file_system_->FindFileByPathSync(file_path, &search_delegate);
     return search_delegate.file();
   }
 
   void FindAndTestFilePath(const FilePath& file_path) {
     GDataFileBase* file = FindFile(file_path);
     ASSERT_TRUE(file) << "File can't be found " << file_path.value();
     EXPECT_EQ(file->GetFilePath(), file_path);
@@ skipping 1310 matching lines @@
       false,  // is_exclusive
       true,  // is_recursive
       base::Bind(&CallbackHelper::FileOperationCallback,
                  callback_helper_.get()));
   message_loop_.RunAllPending();  // Wait to get our result.
   // TODO(gspencer): Uncomment this when we get a blob that
   // works that can be returned from the mock.
   // EXPECT_EQ(base::PLATFORM_FILE_OK, callback_helper_->last_error_);
 }
 
-TEST_F(GDataFileSystemTest, GetFile) {
+TEST_F(GDataFileSystemTest, GetFileFromDownloads) {
   LoadRootFeedDocument("root_feed.json");
 
   GetFileCallback callback =
       base::Bind(&CallbackHelper::GetFileCallback,
                  callback_helper_.get());
 
+  FilePath file_in_root(FILE_PATH_LITERAL("gdata/File 1.txt"));
+  GDataFileBase* file_base = FindFile(file_in_root);
+  GDataFile* file = file_base->AsGDataFile();
+  FilePath downloaded_file = GetCachePathForFile(file);
+
   EXPECT_CALL(*mock_doc_service_,
-              DownloadFile(_, GURL("https://file_content_url/"), _));
+              DownloadFile(file_in_root,
+                           downloaded_file,
+                           GURL("https://file_content_url/"),
+                           _))
+      .Times(1);
 
-  FilePath file_in_root(FILE_PATH_LITERAL("gdata/File 1.txt"));
   file_system_->GetFile(file_in_root, callback);
+  RunAllPendingForCache();
+
   message_loop_.RunAllPending();  // Wait to get our result.
-  EXPECT_STREQ("file_content_url/",
+  EXPECT_STREQ(downloaded_file.value().c_str(),
                callback_helper_->download_path_.value().c_str());
 }
 
+TEST_F(GDataFileSystemTest, GetFileFromCache) {
+  LoadRootFeedDocument("root_feed.json");
+
+  GetFileCallback callback =
+      base::Bind(&CallbackHelper::GetFileCallback,
+                 callback_helper_.get());
+
+  FilePath file_in_root(FILE_PATH_LITERAL("gdata/File 1.txt"));
+  GDataFileBase* file_base = FindFile(file_in_root);
+  GDataFile* file = file_base->AsGDataFile();
+  FilePath downloaded_file = GetCachePathForFile(file);
+
+  // Store something as cached version of this file.
+  TestStoreToCache(file->resource_id(),
+                   file->file_md5(),
+                   GetTestFilePath("root_feed.json"),
+                   base::PLATFORM_FILE_OK);
+
+  // Make sure we don't call downloads at all.
+  EXPECT_CALL(*mock_doc_service_,
+              DownloadFile(file_in_root,
+                           downloaded_file,
+                           GURL("https://file_content_url/"),
+                           _))
+      .Times(0);
+
+  file_system_->GetFile(file_in_root, callback);
+  RunAllPendingForCache();
+
+  message_loop_.RunAllPending();  // Wait to get our result.

[kuan, 2012/03/20 05:22:27]

nit: don't need this because RunAllPendingForCache has it.

[zel, 2012/03/20 05:27:20]

Done.

+  EXPECT_STREQ(downloaded_file.value().c_str(),
+               callback_helper_->download_path_.value().c_str());
+}
+
 TEST_F(GDataFileSystemTest, GetAvailableSpace) {
   GetAvailableSpaceCallback callback =
       base::Bind(&CallbackHelper::GetAvailableSpaceCallback,
                  callback_helper_.get());
 
   EXPECT_CALL(*mock_doc_service_, GetAccountMetadata(_));
 
   file_system_->GetAvailableSpace(callback);
   message_loop_.RunAllPending();  // Wait to get our result.
   EXPECT_EQ(1234, callback_helper_->quota_bytes_used_);
   EXPECT_EQ(12345, callback_helper_->quota_bytes_total_);
 }
 
 }   // namespace gdata