chrome/browser/extensions/extension_webnavigation_apitest.cc - Issue 9737001: Fix crash in AppNotifyChannelSetup when incognito profiles are used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_webnavigation_apitest.cc

Issue 9737001: Fix crash in AppNotifyChannelSetup when incognito profiles are used. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: feedback + test failures Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_webnavigation_apitest.cc

diff --git a/chrome/browser/extensions/extension_webnavigation_apitest.cc b/chrome/browser/extensions/extension_webnavigation_apitest.cc

index 3c9f669cb292e3450ab2c29b1d07b21fb3976f78..a1903836cd6fbb2b8b9a08ad2d9f385c70a63197 100644

--- a/chrome/browser/extensions/extension_webnavigation_apitest.cc

+++ b/chrome/browser/extensions/extension_webnavigation_apitest.cc

@@ -288,8 +288,9 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigationTargetBlankIncognito) {

switches::kAllowLegacyExtensionManifests);

// Wait for the extension to set itself up and return control to us.

- ASSERT_TRUE(RunExtensionSubtestIncognito(

- "webnavigation", "test_targetBlank.html")) << message_;

+ ASSERT_TRUE(RunExtensionSubtest(

+ "webnavigation", "test_targetBlank.html",

+ ExtensionApiTest::kFlagEnableIncognito)) << message_;

ResultCatcher catcher;

« no previous file with comments | « chrome/browser/extensions/extension_tabs_apitest.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »