Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: chrome/browser/chromeos/extensions/external_filesystem_apitest.cc

Issue 9737001: Fix crash in AppNotifyChannelSetup when incognito profiles are used. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: feedback + test failures Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/app/app_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/external_filesystem_apitest.cc
diff --git a/chrome/browser/chromeos/extensions/external_filesystem_apitest.cc b/chrome/browser/chromeos/extensions/external_filesystem_apitest.cc
index 089afd06ee946d4b79367d6bb432587eb52c3e8f..daec195570bdb8e4d5e788d4dcf0c19fa3f30fe1 100644
--- a/chrome/browser/chromeos/extensions/external_filesystem_apitest.cc
+++ b/chrome/browser/chromeos/extensions/external_filesystem_apitest.cc
@@ -30,6 +30,10 @@ namespace {
// The ID of the file browser extension.
const char kFileBrowserExtensionId[] = "ddammdhioacbehjngdmkjcjbnfginlla";
+// Flags used to run the tests with a COMPONENT extension.
+const int kComponentFlags = ExtensionApiTest::kFlagEnableFileAccess |
+ ExtensionApiTest::kFlagLoadAsComponent;
+
// Returns the expected URL for the given path.
GURL GetExpectedURL(const std::string& path) {
return GURL(
@@ -183,15 +187,15 @@ IN_PROC_BROWSER_TEST_F(FileSystemExtensionApiTest, LocalFileSystem) {
IN_PROC_BROWSER_TEST_F(FileSystemExtensionApiTest, FileBrowserTest) {
AddTmpMountPoint();
ASSERT_TRUE(RunExtensionTest("filesystem_handler")) << message_;
- ASSERT_TRUE(RunComponentExtensionSubtest("filebrowser_component",
- "read.html")) << message_;
+ ASSERT_TRUE(RunExtensionSubtest(
+ "filebrowser_component", "read.html", kComponentFlags)) << message_;
}
IN_PROC_BROWSER_TEST_F(FileSystemExtensionApiTest, FileBrowserTestWrite) {
AddTmpMountPoint();
ASSERT_TRUE(RunExtensionTest("filesystem_handler_write")) << message_;
- ASSERT_TRUE(RunComponentExtensionSubtest("filebrowser_component",
- "write.html")) << message_;
+ ASSERT_TRUE(RunExtensionSubtest(
+ "filebrowser_component", "write.html", kComponentFlags)) << message_;
}
IN_PROC_BROWSER_TEST_F(FileSystemExtensionApiTest,
@@ -199,8 +203,8 @@ IN_PROC_BROWSER_TEST_F(FileSystemExtensionApiTest,
AddTmpMountPoint();
ASSERT_TRUE(RunComponentExtensionTest("filesystem_handler_write"))
<< message_;
- ASSERT_TRUE(RunComponentExtensionSubtest("filebrowser_component",
- "write.html")) << message_;
+ ASSERT_TRUE(RunExtensionSubtest(
+ "filebrowser_component", "write.html", kComponentFlags)) << message_;
}
IN_PROC_BROWSER_TEST_F(RemoteFileSystemExtensionApiTest, RemoteMountPoint) {
@@ -231,7 +235,7 @@ IN_PROC_BROWSER_TEST_F(RemoteFileSystemExtensionApiTest, RemoteMountPoint) {
// Returns the path to the temporary file on the local drive.
test_file_path_,
scoped_refptr<webkit_blob::ShareableFileReference>(NULL)));
- ASSERT_TRUE(RunComponentExtensionSubtest(
- "filebrowser_component",
- "remote.html#" + GetPathOnMountPoint(""))) << message_;
+ ASSERT_TRUE(RunExtensionSubtest(
+ "filebrowser_component", "remote.html#" + GetPathOnMountPoint(""),
+ kComponentFlags)) << message_;
}
« no previous file with comments | « no previous file | chrome/browser/extensions/api/app/app_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698