Issue 9735: test_webview_delegate.cc was forked for the Mac test shell, and then

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9735: test_webview_delegate.cc was forked for the Mac test shell, and then (Closed)

Created:
12 years, 1 month ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee, Amanda Walker, tony

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

test_webview_delegate.cc was forked for the Mac test shell, and then the GTK test shell was a fork of that. This change reunifies the Windows and GTK versions by refactoring the basic functionality out. It should be easy enough to fix the Mac one as well following this.

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+270 lines, -875 lines)			Patch
M	webkit/tools/test_shell/SConscript	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/gtk/test_webview_delegate.cc	View	3 chunks	+13 lines, -691 lines	2 comments	Download
M	webkit/tools/test_shell/gtk/webview_host.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.vcproj	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	14 chunks	+23 lines, -181 lines	0 comments	Download
A	webkit/tools/test_shell/test_webview_delegate_win.cc	View	1 chunk	+213 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

12 years, 1 month ago (2008-11-09 18:07:49 UTC) #2

nice.  lgtm

http://codereview.chromium.org/9735/diff/1/3
File webkit/tools/test_shell/gtk/test_webview_delegate.cc (right):

http://codereview.chromium.org/9735/diff/1/3#newcode62
Line 62: // TODO(port): GTK cursor handling.
Nit: NOTIMPLEMENTED()?

http://codereview.chromium.org/9735/diff/1/3#newcode79
Line 79: // MoveWindow(shell_->popupWnd(),
NOTIMPLEMENTED?

Expand Messages | Collapse Messages