dbus/values_util.cc - Issue 9732029: Fix dbus::PopDataAsValue's behavior when a dictionary's keys including dots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dbus/values_util.cc

Issue 9732029: Fix dbus::PopDataAsValue's behavior when a dictionary's keys including dots (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: _ Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dbus/values_util.cc

diff --git a/dbus/values_util.cc b/dbus/values_util.cc

index c42237415c01fb607eee42ebcf19b42d2de2ea79..b78638dcbce8d0898ede4c3c7e94aefe417d7e0c 100644

--- a/dbus/values_util.cc

+++ b/dbus/values_util.cc

@@ -57,7 +57,7 @@ bool PopDictionaryEntries(MessageReader* reader,

Value* value = PopDataAsValue(&entry_reader);

if (!value)

return false;

- dictionary_value->Set(key_string, value);

+ dictionary_value->SetWithoutPathExpansion(key_string, value);

satorux1 2012/03/20 16:55:09 Wow, that's subtle...

}

return true;

}

« no previous file with comments | « no previous file | dbus/values_util_unittest.cc » ('j') | no next file with comments »