Issue 9732029: Fix dbus::PopDataAsValue's behavior when a dictionary's keys including dots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9732029: Fix dbus::PopDataAsValue's behavior when a dictionary's keys including dots (Closed)

Created:
8 years, 9 months ago by hashimoto

Modified:
8 years, 9 months ago

Reviewers:
satorux1

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix dbus::PopDataAsValue's behavior when a dictionary's keys including dots BUG=None TEST=dbus_unittests --gtest_filter="ValuesUtilTest.PopDictinoaryWithDottedStringKey" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127727

Patch Set 1 : _ #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -2 lines)			Patch
	M	dbus/values_util.cc	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	dbus/values_util_unittest.cc	View		2 chunks	+45 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

satorux1

LGTM http://codereview.chromium.org/9732029/diff/4001/dbus/values_util.cc File dbus/values_util.cc (right): http://codereview.chromium.org/9732029/diff/4001/dbus/values_util.cc#newcode60 dbus/values_util.cc:60: dictionary_value->SetWithoutPathExpansion(key_string, value); Wow, that's subtle...

8 years, 9 months ago (2012-03-20 16:55:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/9732029/4001

8 years, 9 months ago (2012-03-20 17:05:48 UTC) #3

Change committed as 127727

Expand Messages | Collapse Messages