chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm - Issue 9732012: [Mac] Have BaseBubbleController dismiss bubbles when they would lose key state on 10.8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

Issue 9732012: [Mac] Have BaseBubbleController dismiss bubbles when they would lose key state on 10.8. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: local changes Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

index 156c096f6037f77b15551d808dc007841e406292..ba611fd966c6578a3be65651f4b4e0540bed54c2 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

@@ -221,6 +221,7 @@ void BookmarkBubbleNotificationBridge::Observe(

[parentWindow addChildWindow:window ordered:NSWindowAbove];

[window makeKeyAndOrderFront:self];

+ [self registerKeyStateEventTap];

Nico 2012/03/20 16:18:40 :-/

Robert Sesek 2012/03/21 21:55:12 Yeah, but calling super for this method turned out

}

- (void)close {

« no previous file with comments | « chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm ('k') | no next file » | no next file with comments »