Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: ppapi/cpp/var.cc

Issue 9731003: PPAPI: Remove out-dated or unnecessary TODOs from public files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ppapi/api/ppb_graphics_2d.idl ('K') | « ppapi/c/ppb_graphics_2d.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/cpp/var.cc
diff --git a/ppapi/cpp/var.cc b/ppapi/cpp/var.cc
index 7748ff275ce4f547c768e666131f928b8ed93e98..881ce3288e02e93b0997b8b9d30c631f9417c16a 100644
--- a/ppapi/cpp/var.cc
+++ b/ppapi/cpp/var.cc
@@ -219,9 +219,6 @@ std::string Var::DebugString() const {
} else if (is_bool()) {
snprintf(buf, sizeof(buf), AsBool() ? "Var(true)" : "Var(false)");
} else if (is_int()) {
- // Note that the following static_cast is necessary because
- // NativeClient's int32_t is actually "long".
- // TODO(sehr,polina): remove this after newlib is changed.
dmichael (off chromium) 2012/03/19 17:41:52 this static_cast is correct; there's no need to re
snprintf(buf, sizeof(buf), "Var(%d)", static_cast<int>(AsInt()));
} else if (is_double()) {
snprintf(buf, sizeof(buf), "Var(%f)", AsDouble());
@@ -236,8 +233,6 @@ std::string Var::DebugString() const {
}
snprintf(buf, sizeof(buf), format, str.c_str());
} else if (is_array_buffer()) {
- // TODO(dmichael): We could make this dump hex. Maybe DebugString should be
- // virtual?
dmichael (off chromium) 2012/03/19 17:41:52 Just a nice-to-have.
snprintf(buf, sizeof(buf), "Var(ARRAY_BUFFER)");
} else if (is_object()) {
snprintf(buf, sizeof(buf), "Var(OBJECT)");
« ppapi/api/ppb_graphics_2d.idl ('K') | « ppapi/c/ppb_graphics_2d.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698