Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 9731003: PPAPI: Remove out-dated or unnecessary TODOs from public files. (Closed)

Created:
8 years, 9 months ago by dmichael (off chromium)
Modified:
8 years, 9 months ago
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

PPAPI: Remove out-dated or unnecessary TODOs from public files. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127918

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -29 lines) Patch
M ppapi/api/ppb_file_system.idl View 1 chunk +0 lines, -5 lines 1 comment Download
M ppapi/api/ppb_graphics_2d.idl View 1 chunk +0 lines, -7 lines 2 comments Download
M ppapi/c/ppb_file_system.h View 2 chunks +1 line, -5 lines 0 comments Download
M ppapi/c/ppb_graphics_2d.h View 2 chunks +1 line, -7 lines 0 comments Download
M ppapi/cpp/var.cc View 2 chunks +0 lines, -5 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
dmichael (off chromium)
http://codereview.chromium.org/9731003/diff/1/ppapi/api/ppb_file_system.idl File ppapi/api/ppb_file_system.idl (left): http://codereview.chromium.org/9731003/diff/1/ppapi/api/ppb_file_system.idl#oldcode59 ppapi/api/ppb_file_system.idl:59: */ The first sentence in the documentation covers this, ...
8 years, 9 months ago (2012-03-19 17:41:52 UTC) #1
cstefansen
lgtm Thanks for taking care of this.
8 years, 9 months ago (2012-03-20 00:50:59 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 9 months ago (2012-03-20 15:08:48 UTC) #3
dmichael (off chromium)
+bbudge to have a committer review (or just rubber stamp if you like).
8 years, 9 months ago (2012-03-21 02:42:40 UTC) #4
bbudge-google
lgtm
8 years, 9 months ago (2012-03-21 05:39:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/9731003/1
8 years, 9 months ago (2012-03-21 05:53:25 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-21 07:01:11 UTC) #7
Change committed as 127918

Powered by Google App Engine
This is Rietveld 408576698