Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Unified Diff: build/common.gypi

Issue 9730018: Simple gyp rule cleanup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index c52c183a1354ae0ab73debbdb10e8bb600cf3086..eb5e8237d259719dbf2a50d30556bc0edcb75a3a 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -13,8 +13,7 @@
# weird. This is done so that 'host_arch', 'chromeos', etc are defined as
# variables within the outer variables dict here. This is necessary
# to get these variables defined for the conditions within this variables
- # dict that operate on these variables (e.g., for setting 'toolkit_views',
- # we need to have 'chromeos' already set).
+ # dict that operate on these variables.
'variables': {
'variables': {
'variables': {
@@ -319,25 +318,25 @@
# Flags to use X11 on non-Mac POSIX platforms
['OS=="win" or OS=="mac" or OS=="android"', {
'use_glib%': 0,
- 'toolkit_uses_gtk%': 0,
'use_x11%': 0,
}, {
- # TODO(dnicoara) Wayland build should have these disabled, but
- # currently GTK and X is too spread and it's hard to completely
- # remove every dependency.
'use_glib%': 1,
- 'toolkit_uses_gtk%': 1,
'use_x11%': 1,
}],
+
+ # Set toolkit_uses_gtk for the Chromium browser on Linux.
+ ['OS=="linux" and chromeos==0', {
+ 'toolkit_uses_gtk%': 1,
+ }, {
+ 'toolkit_uses_gtk%': 0,
+ }],
+
# We always use skia text rendering in Aura on Windows, since GDI
# doesn't agree with our BackingStore.
# TODO(beng): remove once skia text rendering is on by default.
['use_aura==1 and OS=="win"', {
'enable_skia_text%': 1,
}],
- ['use_aura==1 and OS!="win"', {
- 'toolkit_uses_gtk%': 0,
- }],
# A flag to enable or disable our compile-time dependency
# on gnome-keyring. If that dependency is disabled, no gnome-keyring
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698