Make the file chooser use PP_ArrayOutput

ppapi/proxy/ppapi_messages.h

Index: ppapi/proxy/ppapi_messages.h
diff --git a/ppapi/proxy/ppapi_messages.h b/ppapi/proxy/ppapi_messages.h
index dbcbbd1a16594470f6e07a10a035ed70cbb53de9..62cb3b4933bd18df47caf9eabc5c26f7a0b78e49 100644
--- a/ppapi/proxy/ppapi_messages.h
+++ b/ppapi/proxy/ppapi_messages.h
@@ -678,8 +678,8 @@ IPC_SYNC_MESSAGE_ROUTED3_1(PpapiHostMsg_PPBFileChooser_Create,
                            ppapi::HostResource /* result */)
 IPC_MESSAGE_ROUTED4(PpapiHostMsg_PPBFileChooser_Show,
                     ppapi::HostResource /* file_chooser */,
-                    bool /* save_as */,
-                    std::string /* suggested_file_name */,
+                    PP_Bool /* save_as */,

[viettrungluu, 2012/03/26 16:55:19]

Is there any particular advantage to this change?

[brettw, 2012/03/26 17:08:06]

This saves conversion code. This way to only convert from PP_Bool-> bool once.

+                    ppapi::proxy::SerializedVar /* suggested_file_name */,

[viettrungluu, 2012/03/26 16:55:19]

And this one?

[brettw, 2012/03/26 17:08:06]

Ditto, otherwise we need to convert from a PP_Var to a string in the proxy, then
back to a PP_Var, then back to a string. The old code had a std::string in the
_APi class and did the string conversion in the thunk layer which is against our
rules (thunks should be literally just thunks to aid in future autogeneration).

                     bool /* require_user_gesture */)
 
 // PPB_FileIO.