Make the file chooser use PP_ArrayOutput

ppapi/proxy/ppapi_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message header, no traditional include guard.
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/file_path.h"
@@ skipping 660 matching lines @@
                            PP_Bool /* result */)
 
 // PPB_FileChooser.
 IPC_SYNC_MESSAGE_ROUTED3_1(PpapiHostMsg_PPBFileChooser_Create,
                            PP_Instance /* instance */,
                            int /* mode */,
                            std::string /* accept_mime_types */,
                            ppapi::HostResource /* result */)
 IPC_MESSAGE_ROUTED4(PpapiHostMsg_PPBFileChooser_Show,
                     ppapi::HostResource /* file_chooser */,
-                    bool /* save_as */,
-                    std::string /* suggested_file_name */,
+                    PP_Bool /* save_as */,

[viettrungluu, 2012/03/26 16:55:19]

Is there any particular advantage to this change?

[brettw, 2012/03/26 17:08:06]

This saves conversion code. This way to only convert from PP_Bool-> bool once.

+                    ppapi::proxy::SerializedVar /* suggested_file_name */,

[viettrungluu, 2012/03/26 16:55:19]

And this one?

[brettw, 2012/03/26 17:08:06]

Ditto, otherwise we need to convert from a PP_Var to a string in the proxy, then
back to a PP_Var, then back to a string. The old code had a std::string in the
_APi class and did the string conversion in the thunk layer which is against our
rules (thunks should be literally just thunks to aid in future autogeneration).

                     bool /* require_user_gesture */)
 
 // PPB_FileIO.
 IPC_SYNC_MESSAGE_ROUTED1_1(PpapiHostMsg_PPBFileIO_Create,
                            PP_Instance /* instance */,
                            ppapi::HostResource /* result */)
 IPC_MESSAGE_ROUTED3(PpapiHostMsg_PPBFileIO_Open,
                     ppapi::HostResource /* host_resource */,
                     ppapi::HostResource /* file_ref_resource */,
                     int32_t /* open_flags */)
@@ skipping 604 matching lines @@
 IPC_MESSAGE_CONTROL2(PpapiHostMsg_PPBTCPServerSocket_Accept,
                      int32 /* tcp_client_socket_routing_id */,
                      uint32 /* server_socket_id */)
 IPC_MESSAGE_CONTROL1(PpapiHostMsg_PPBTCPServerSocket_Destroy,
                      uint32 /* socket_id */)
 
 // PPB_Font.
 IPC_SYNC_MESSAGE_CONTROL0_1(PpapiHostMsg_PPBFont_GetFontFamilies,
                             std::string /* result */)
 #endif  // !defined(OS_NACL)