Log connection type to syslogs and to the server.

remoting/protocol/transport.h

Index: remoting/protocol/transport.h
diff --git a/remoting/protocol/transport.h b/remoting/protocol/transport.h
index e892404e5d0f71f5522a8d3a6b16429bcebf1226..df5811430f7bfbf6e0f3503797bf227f378a5de6 100644
--- a/remoting/protocol/transport.h
+++ b/remoting/protocol/transport.h
@@ -52,6 +52,11 @@ struct TransportRoute {
     RELAY,
   };
 
+  TransportRoute();
+  ~TransportRoute();
+
+  std::string GetTypeString() const;

[simonmorris, 2012/03/19 22:17:05]

Could this expose a RouteType, instead of a string derived from a RouteType?

The current approach leads to errors if a later CL adds/changes one of the
strings, without making sure that all the consumers of the string will work
properly. Some of the ultimate consumers of the string are a long way from this
code, but nearer to the HostEventLoggers and LogToServer.

[Sergey Ulanov, 2012/03/19 23:21:03]

This is a struct and the type field is public. This is just a helper method to
get string representation of the type.

I've changed this method to static, and pass RouteType instead of a string to
AddConnectionTypeField(), but it still uses this function to convert the value -
otherwise I would have to duplicate this code.

+
   RouteType type;
   net::IPEndPoint remote_address;
   net::IPEndPoint local_address;