Log connection type to syslogs and to the server.

remoting/protocol/transport.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines the interface for peer-to-peer transport. There
 // are two types of transport: StreamTransport and DatagramTransport.
 // They must both be created using TransportFactory instances and they
 // provide the same interface, except that one should be used for
 // reliable stream connection and the other one for unreliable
 // datagram connection. The Transport interface itself doesn't provide
@@ skipping 34 matching lines @@
 class ChannelAuthenticator;
 struct TransportConfig;
 
 struct TransportRoute {
   enum RouteType {
     DIRECT,
     STUN,
     RELAY,
   };
 
+  TransportRoute();
+  ~TransportRoute();
+
+  std::string GetTypeString() const;

[simonmorris, 2012/03/19 22:17:05]

Could this expose a RouteType, instead of a string derived from a RouteType?

The current approach leads to errors if a later CL adds/changes one of the
strings, without making sure that all the consumers of the string will work
properly. Some of the ultimate consumers of the string are a long way from this
code, but nearer to the HostEventLoggers and LogToServer.

[Sergey Ulanov, 2012/03/19 23:21:03]

This is a struct and the type field is public. This is just a helper method to
get string representation of the type.

I've changed this method to static, and pass RouteType instead of a string to
AddConnectionTypeField(), but it still uses this function to convert the value -
otherwise I would have to duplicate this code.

+
   RouteType type;
   net::IPEndPoint remote_address;
   net::IPEndPoint local_address;
 };
 
 class Transport : public base::NonThreadSafe {
  public:
   class EventHandler {
    public:
     EventHandler() {};
@@ skipping 74 matching lines @@
   virtual scoped_ptr<DatagramTransport> CreateDatagramTransport() = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TransportFactory);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_TRANSPORT_H_