ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_websocket_rpc_server.cc - Issue 9724007: WebSocket Pepper API: fix data corruption at ReceiveMessage in NaCl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_websocket_rpc_server.cc

Issue 9724007: WebSocket Pepper API: fix data corruption at ReceiveMessage in NaCl (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: remove flaky prefix Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ppapi/native_client/src/shared/ppapi_proxy/browser_callback.cc ('K') | « ppapi/native_client/src/shared/ppapi_proxy/browser_callback.cc ('k') | ppapi/tests/test_websocket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_websocket_rpc_server.cc

diff --git a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_websocket_rpc_server.cc b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_websocket_rpc_server.cc

index 65c08775d4ea4bc8662374a7bfda9395baf46f1f..94e12d38379417cb59b084e517fdab78f8068e92 100644

--- a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_websocket_rpc_server.cc

+++ b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_websocket_rpc_server.cc

@@ -151,7 +151,7 @@ void PpbWebSocketRpcServer::PPB_WebSocket_ReceiveMessage(

ws, callback_var, remote_callback);

DebugPrintf("PPB_WebSocket::ReceiveMessage: pp_error=%"NACL_PRId32"\n",

*pp_error);

+ CHECK(*pp_error != PP_OK); // Should not complete synchronously

if (*pp_error != PP_OK_COMPLETIONPENDING)

DeleteRemoteCallbackInfo(remote_callback);

rpc->result = NACL_SRPC_RESULT_OK;