Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 9722043: Refactor code generation for global declarations. (Closed)

Created:
8 years, 9 months ago by rossberg
Modified:
8 years, 8 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Refactor code generation for global declarations. (Baseline is http://codereview.chromium.org/9704054/) R=fschneider@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11332

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -110 lines) Patch
M src/arm/full-codegen-arm.cc View 4 chunks +14 lines, -5 lines 0 comments Download
M src/full-codegen.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +6 lines, -37 lines 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 7 chunks +34 lines, -55 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 4 chunks +14 lines, -5 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 4 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
8 years, 9 months ago (2012-03-19 16:13:53 UTC) #1
fschneider
LGTM. You could consider lazily creating the FixedArray that holds the declared globals instead of ...
8 years, 8 months ago (2012-04-11 14:05:34 UTC) #2
rossberg
8 years, 8 months ago (2012-04-16 11:54:58 UTC) #3
On 2012/04/11 14:05:34, fschneider wrote:
> LGTM.
> 
> You could consider lazily creating the FixedArray that holds the declared
> globals instead of first creating a ZoneList and then copying it. This way the
> code maybe even shorter.

The problem with that is that I don't know the length of the FixedArray ahead of
time.

Powered by Google App Engine
This is Rietveld 408576698