Add CreateFromIPv[46]Address() in PPB_NetAddress_Private.

ppapi/cpp/private/net_address_private.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/cpp/private/net_address_private.h"
 
 #include "ppapi/c/pp_bool.h"
 #include "ppapi/cpp/module.h"
 #include "ppapi/cpp/module_impl.h"
 #include "ppapi/cpp/var.h"
 
 namespace pp {
 
 namespace {
 
+template <> const char* interface_name<PPB_NetAddress_Private_1_1>() {
+  return PPB_NETADDRESS_PRIVATE_INTERFACE_1_1;
+}
+
 template <> const char* interface_name<PPB_NetAddress_Private_1_0>() {
   return PPB_NETADDRESS_PRIVATE_INTERFACE_1_0;
 }
 
 template <> const char* interface_name<PPB_NetAddress_Private_0_1>() {
   return PPB_NETADDRESS_PRIVATE_INTERFACE_0_1;
 }
 
 }  // namespace
 
 // static
 bool NetAddressPrivate::IsAvailable() {
   return has_interface<PPB_NetAddress_Private_1_0>() ||

[viettrungluu, 2012/03/21 17:42:55]

You should update all this.

[Sergey Ulanov, 2012/03/21 18:14:51]

Done.

          has_interface<PPB_NetAddress_Private_0_1>();
 }
 
 // static
 bool NetAddressPrivate::AreEqual(const PP_NetAddress_Private& addr1,
                                  const PP_NetAddress_Private& addr2) {
   if (has_interface<PPB_NetAddress_Private_1_0>()) {

[viettrungluu, 2012/03/21 17:42:55]

And add a 1.1 case here.

[Sergey Ulanov, 2012/03/21 18:14:51]

Done.

     return !!get_interface<PPB_NetAddress_Private_1_0>()->AreEqual(&addr1,
                                                                    &addr2);
   }
   if (has_interface<PPB_NetAddress_Private_0_1>()) {
     return !!get_interface<PPB_NetAddress_Private_0_1>()->AreEqual(&addr1,
                                                                    &addr2);
   }
   return false;
 }
 
 // static
 bool NetAddressPrivate::AreHostsEqual(const PP_NetAddress_Private& addr1,
                                       const PP_NetAddress_Private& addr2) {
   if (has_interface<PPB_NetAddress_Private_1_0>()) {

[viettrungluu, 2012/03/21 17:42:55]

Etc.

[Sergey Ulanov, 2012/03/21 18:14:51]

Done.

     return !!get_interface<PPB_NetAddress_Private_1_0>()->AreHostsEqual(&addr1,
                                                                         &addr2);
   }
   if (has_interface<PPB_NetAddress_Private_0_1>()) {
     return !!get_interface<PPB_NetAddress_Private_0_1>()->AreHostsEqual(&addr1,
                                                                         &addr2);
   }
   return false;
 }
 
@@ skipping 73 matching lines @@
                                    uint16_t address_size) {
   if (has_interface<PPB_NetAddress_Private_1_0>()) {
     return PP_ToBool(get_interface<PPB_NetAddress_Private_1_0>()->GetAddress(
         &addr,
         address,
         address_size));
   }
   return false;
 }
 
+// static
+void NetAddressPrivate::CreateFromIPv4Address(
+    const uint8_t ip[4],
+    uint16_t port,
+    struct PP_NetAddress_Private* addr_out) {
+  if (has_interface<PPB_NetAddress_Private_1_1>()) {
+    get_interface<PPB_NetAddress_Private_1_1>()->CreateFromIPv4Address(
+        ip, port, addr_out);
+  }

[viettrungluu, 2012/03/21 17:42:55]

Probably this should either return a bool indicating success/failure, or at
least set set |*addr_out| to something predictable (and invalid), in the case
that 1.1 isn't available.

(I guess the same could be said for |GetAnyAddress()|. Oops.)

[Sergey Ulanov, 2012/03/21 18:14:51]

Yes, agree. Done. 
Right, that's why didn't make it return bool in the first place. Is it too late
to fix GetAnyAddress()?

[viettrungluu, 2012/03/22 04:54:34]

Fixing GetAnyAddress() should be fine.

In general, changes to the C++ wrappers of the following form should be fine
(esp. for Dev interfaces):
- Changes that don't break users of the wrappers (adding a bool return should
fall into this category).
- Changes that break users in an obvious way (e.g., during compile!) and for
which the changes to the code using the wrappers aren't too onerous.

[Sergey Ulanov, 2012/03/22 17:43:48]

Done.

+}
+
+// static
+void NetAddressPrivate::CreateFromIPv6Address(

[viettrungluu, 2012/03/21 17:42:55]

"

[Sergey Ulanov, 2012/03/21 18:14:51]

Done.

+    const uint8_t ip[16],
+    uint32_t scope_id,
+    uint16_t port,
+    struct PP_NetAddress_Private* addr_out) {
+  if (has_interface<PPB_NetAddress_Private_1_1>()) {
+    get_interface<PPB_NetAddress_Private_1_1>()->CreateFromIPv6Address(
+        ip, scope_id, port, addr_out);
+  }
+}
+
 }  // namespace pp