Add CreateFromIPv[46]Address() in PPB_NetAddress_Private.

ppapi/api/private/ppb_net_address_private.idl

 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /**
  * This file defines the <code>PPB_NetAddress_Private</code> interface.
  */
 
 label Chrome {
     M17 = 0.1,
-    M19 = 1.0
+    M19_0 = 1.0,
+    M19_1 = 1.1
 };
 
 [assert_size(4)]
 enum PP_NetAddressFamily_Private {
   /**
    * The address family is unspecified.
    */
   PP_NETADDRESSFAMILY_UNSPECIFIED = 0,
   /**
    * The Internet Protocol version 4 (IPv4) address family.
@@ skipping 38 matching lines @@
     */
   PP_Var Describe([in] PP_Module module,
                   [in] PP_NetAddress_Private addr,
                   [in] PP_Bool include_port);
 
   /**
     * Replaces the port in the given source address. Returns PP_TRUE on success.
     */
   PP_Bool ReplacePort([in] PP_NetAddress_Private src_addr,
                       [in] uint16_t port,
-                      [out] PP_NetAddress_Private dest_addr);
+                      [out] PP_NetAddress_Private addr_out);
 
   /**
     * Gets the "any" address (for IPv4 or IPv6); for use with UDP Bind.
     */
   void GetAnyAddress([in] PP_Bool is_ipv6,
                      [out] PP_NetAddress_Private addr);
 
   /**
     * Gets the address family.
     */
@@ skipping 10 matching lines @@
     * Gets the address. The output, address, must be large enough for the
     * current socket family. The output will be the binary representation of an
     * address for the current socket family. For IPv4 and IPv6 the address is in
     * network byte order. PP_TRUE is returned if the address was successfully
     * retrieved.
     */
   [version=1.0]
   PP_Bool GetAddress([in] PP_NetAddress_Private addr,
                      [out] mem_t address,
                      [in] uint16_t address_size);
+
+  /**
+    * Creates NetAddress with the specified IPv4 address and port
+    * number.
+    */
+  [version=1.1]
+  void CreateFromIPv4Address([in] uint8_t[4] ip,
+                             [in] uint16_t port,
+                             [out] PP_NetAddress_Private addr_out);
+  /**
+    * Creates NetAddress with the specified IPv6 address, scope_id and
+    * port number.
+    */
+  [version=1.1]
+  void CreateFromIPv6Address([in] uint8_t[16] ip,

[dmichael (off chromium), 2012/03/21 19:33:17]

It seems like the natural way to represent this is an array of 8 uint16_ts.
That's what your test seems to want, as well. Is there a reason you are using
uint8_t?

[Sergey Ulanov, 2012/03/21 19:44:51]

I don't agree it's more natural than uint8_t. E.g. in6_addr represents IPv6
addresses as sequence of 16 bytes. So is net::IPAddressSequence. And there is no
need to worry about byte order when you represent address as a sequence of
bytes.
That test was there before, if I wrote it I wouldn't use uint16_t.

[Sergey Ulanov, 2012/03/21 19:46:35]

Sorry, I meant net::IPAddressNumber.

[viettrungluu, 2012/03/22 04:54:34]

I agree that it should be an array of |uint8_t|s; that way there's no question
of host-versus-network byte order.
That's a case of the common, convenient human representation versus the standard
representation.

+                             [in] uint32_t scope_id,
+                             [in] uint16_t port,
+                             [out] PP_NetAddress_Private addr_out);
 };