Add CreateFromIPv[46]Address() in PPB_NetAddress_Private.

ppapi/api/private/ppb_net_address_private.idl

 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /**
  * This file defines the <code>PPB_NetAddress_Private</code> interface.
  */
 
 label Chrome {
     M17 = 0.1,
     M19 = 1.0

[Sergey Ulanov, 2012/03/16 21:32:53]

Not sure if I need to add 1.1 because it's still M19

[viettrungluu, 2012/03/16 22:19:15]

Yes you do.

[Sergey Ulanov, 2012/03/16 22:31:17]

Ok, then what label should I use here for 1.1?
If I use M19 for both 1.1 and 1.0 then generator.py generates C headers for 1.1,
but not for 1.0

[noelallen1, 2012/03/20 00:48:58]

It's a question of what you are planning to ship.

We shipped M17 apparently.  There is no M18?
We could change M19=1.0 to M18_X and add M19=1.1 or you can add M19.1=1.1

But the list of labels should be clean for shipping.  Those are only transition
numbers.

On 2012/03/16 22:31:17, sergeyu wrote:

[noelallen1, 2012/03/20 01:01:22]

Here's my understanding.

A new function was added to an emerging interface version M19.  The definition
of M19 is not set in stone until we release it (basically branch to dev).

So as long as this CL also updates all users of this API (the M19 version) such
as any PPAPI unit tests, any NaCl proxy, other PPAPI plugins, etc... then it
should be safe to add to the end.

vlettrungluu - Are you using this interface somewhere else, is that why you want
the version to be 1.1?


On 2012/03/20 00:48:58, noelallen1 wrote:

[viettrungluu, 2012/03/20 12:51:34]

Version 1.0 is already being used by Pepper Flash, and we obviously don't have
the ability to update/ship that in absolute lockstep with Chrome.

In general, one should never assume that one has the ability to "update all
users". Version numbers themselves are cheap and -- once an interface has been
implemented so that it's at all usable -- any (ABI-level) incompatible change
should come with a version number change.

[viettrungluu, 2012/03/20 12:51:34]

If we put "M19 = 1.1", will the version 1.0 struct will still appear in the
generated header? (I know that the 0.1 struct will, but is that because 0.1 <
1.1, or because "M17 = 0.1" is in the list?)

[Sergey Ulanov, 2012/03/20 16:52:53]

Yes, but this particular CL just adds new methods to the interface, so this
won't break old plugins that already use 1.0.

[Sergey Ulanov, 2012/03/20 16:52:53]

No. 1.0 will be in the header only when 1.0 and 1.1 have different labels.
because M17 = 0.1 and M17 != M19. Each generated interface has to have a unique
label.

As Noel noted above, we could have M19_0=1.0 and M19_1=1.1, but it would have to
be cleaned up before M19 branches. Given that addition of new methods to an
interface cannot not break any existing plugins, I don't see any problems with
just keeping the version at 1.0.

 };
 
 [assert_size(4)]
 enum PP_NetAddressFamily_Private {
   /**
    * The address family is unspecified.
    */
   PP_NETADDRESSFAMILY_UNSPECIFIED = 0,
   /**
    * The Internet Protocol version 4 (IPv4) address family.
@@ skipping 38 matching lines @@
     */
   PP_Var Describe([in] PP_Module module,
                   [in] PP_NetAddress_Private addr,
                   [in] PP_Bool include_port);
 
   /**
     * Replaces the port in the given source address. Returns PP_TRUE on success.
     */
   PP_Bool ReplacePort([in] PP_NetAddress_Private src_addr,
                       [in] uint16_t port,
-                      [out] PP_NetAddress_Private dest_addr);
+                      [out] PP_NetAddress_Private addr_out);
 
   /**
     * Gets the "any" address (for IPv4 or IPv6); for use with UDP Bind.
     */
   void GetAnyAddress([in] PP_Bool is_ipv6,
                      [out] PP_NetAddress_Private addr);
 
   /**
     * Gets the address family.
     */
@@ skipping 10 matching lines @@
     * Gets the address. The output, address, must be large enough for the
     * current socket family. The output will be the binary representation of an
     * address for the current socket family. For IPv4 and IPv6 the address is in
     * network byte order. PP_TRUE is returned if the address was successfully
     * retrieved.
     */
   [version=1.0]
   PP_Bool GetAddress([in] PP_NetAddress_Private addr,
                      [out] mem_t address,
                      [in] uint16_t address_size);
+
+  /**
+    * Creates NetAddress with the specified IPv4 address and port
+    * number.
+    */
+  [version=1.0]

[viettrungluu, 2012/03/16 22:19:15]

Should be version 1.1.

+  void CreateFromIPv4Address([in] uint8_t[4] ip,
+                             [in] uint16_t port,
+                             [out] PP_NetAddress_Private addr_out);
+  /**
+    * Creates NetAddress with the specified IPv6 address, scope_id and
+    * port number.
+    */
+  [version=1.0]
+  void CreateFromIPv6Address([in] uint8_t[16] ip,
+                             [in] uint32_t scope_id,
+                             [in] uint16_t port,
+                             [out] PP_NetAddress_Private addr_out);
 };