Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 9721017: Rename ibus_input_methods.txt to input_methods.txt. (Closed)

Created:
8 years, 9 months ago by Yusuke Sato
Modified:
8 years, 9 months ago
Reviewers:
mazda
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org, Zachary Kuznia
Visibility:
Public.

Description

Rename ibus_input_methods.txt to input_methods.txt. The prefix "ibus_" is no longer relevant because IBus is not used anymore for a keyboard whose ID starts with "xkb:". Another reason to avoid the prefix is that we're likely going to reimplement some of the input methods as Chrome extensions. BUG=chromium-os:19655 TEST=try Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127471 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127914 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128116

Patch Set 1 #

Patch Set 2 : review #

Patch Set 3 : rebase #

Patch Set 4 : fix build error #

Patch Set 5 : re-retry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -387 lines) Patch
D chrome/browser/chromeos/input_method/gen_ibus_input_methods.py View 1 chunk +0 lines, -124 lines 0 comments Download
A + chrome/browser/chromeos/input_method/gen_input_methods.py View 4 chunks +23 lines, -24 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller.cc View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
D chrome/browser/chromeos/input_method/ibus_input_methods.txt View 1 chunk +0 lines, -209 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method.gyp View 2 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_whitelist.cc View 1 2 chunks +10 lines, -10 lines 0 comments Download
A + chrome/browser/chromeos/input_method/input_methods.txt View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Yusuke Sato
8 years, 9 months ago (2012-03-19 01:07:31 UTC) #1
mazda
lgtm
8 years, 9 months ago (2012-03-19 04:57:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9721017/1033
8 years, 9 months ago (2012-03-19 07:28:22 UTC) #3
commit-bot: I haz the power
Try job failure for 9721017-1033 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-19 09:22:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9721017/1033
8 years, 9 months ago (2012-03-19 10:07:15 UTC) #5
commit-bot: I haz the power
Try job failure for 9721017-1033 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-19 11:55:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9721017/1033
8 years, 9 months ago (2012-03-19 12:40:39 UTC) #7
commit-bot: I haz the power
Try job failure for 9721017-1033 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-19 14:30:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9721017/13001
8 years, 9 months ago (2012-03-21 23:26:22 UTC) #9
commit-bot: I haz the power
8 years, 9 months ago (2012-03-22 00:45:39 UTC) #10
Change committed as 128116

Powered by Google App Engine
This is Rietveld 408576698