Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 9721011: MIPS: Implement missing functions in regexp-macro-assembler. (Closed)

Created:
8 years, 9 months ago by kalmard
Modified:
8 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Implement missing functions in regexp-macro-assembler. BUG= TEST=

Patch Set 1 #

Patch Set 2 : rebased on r11230 #

Patch Set 3 : Removed CheckNotRegistersEqual from all architectures. #

Patch Set 4 : Reverted to the bare minimum change that's needed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/mips/regexp-macro-assembler-mips.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
kalmard
Please note: We noticed that CheckNotRegistersEqual is not actually called from anywhere. This patch contains ...
8 years, 9 months ago (2012-03-17 10:42:24 UTC) #1
danno
If these are not used at all, I suggest removing them completely for all platforms ...
8 years, 9 months ago (2012-03-21 08:43:57 UTC) #2
kalmard
rebased on r11230
8 years, 8 months ago (2012-04-05 08:37:59 UTC) #3
Erik Corry
We can't land this because it adds unused code (CheckNotRegistersEqual) to MIPS, when it should ...
8 years, 8 months ago (2012-04-12 09:31:11 UTC) #4
kalmard
Thanks for the review. I took the liberty of updating this CL to remove all ...
8 years, 8 months ago (2012-04-12 10:29:47 UTC) #5
danno
Please separate the CLs so that the code that needs to be landed for MIPS ...
8 years, 8 months ago (2012-04-12 10:41:36 UTC) #6
kalmard
On 2012/04/12 10:41:36, danno wrote: > Please separate the CLs so that the code that ...
8 years, 8 months ago (2012-04-12 10:55:28 UTC) #7
Erik Corry
LGTM, landed as 11314
8 years, 8 months ago (2012-04-13 11:47:44 UTC) #8
kalmard
8 years, 8 months ago (2012-04-14 08:20:06 UTC) #9
Thanks for landing! Closing.

Powered by Google App Engine
This is Rietveld 408576698