Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1794)

Unified Diff: net/base/host_resolver_impl.cc

Issue 9721002: [net/dns] Removes locking from DnsConfigServiceWin and adds local computer name. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Responded to review. Added normalization and comments. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/dns/dns_config_service.h » ('j') | net/dns/dns_config_service_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/host_resolver_impl.cc
diff --git a/net/base/host_resolver_impl.cc b/net/base/host_resolver_impl.cc
index c1b7a3fc07827e10b69334d7ed91bf0441e6a1e8..8ae2480d02202126bf7cef5348434dbdb09f1e37 100644
--- a/net/base/host_resolver_impl.cc
+++ b/net/base/host_resolver_impl.cc
@@ -1806,7 +1806,9 @@ HostResolverImpl::Key HostResolverImpl::GetEffectiveKeyForRequest(
if (ipv6_probe_monitoring_)
effective_flags |= HOST_RESOLVER_DEFAULT_FAMILY_SET_DUE_TO_NO_IPV6;
}
- return Key(info.hostname(), effective_address_family, effective_flags);
+ return Key(StringToLowerASCII(info.hostname()),
mmenke 2012/03/22 19:36:08 May want to have a unit test that depends on this.
cbentzel 2012/03/22 19:45:15 I'm not sure you want to do this here. It looks li
mmenke 2012/03/22 19:55:09 Err...wait...Doesn't GURL automatically lowercase
mmenke 2012/03/22 19:58:36 Domains used by PAC script don't go through a GURL
+ effective_address_family,
+ effective_flags);
}
void HostResolverImpl::AbortAllInProgressJobs() {
« no previous file with comments | « no previous file | net/dns/dns_config_service.h » ('j') | net/dns/dns_config_service_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698