Issue 9720021: npapi plugins: Make sure WebPlugin has no key functions on mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9720021: npapi plugins: Make sure WebPlugin has no key functions on mac. (Closed)

Created:
8 years, 9 months ago by Nico

Modified:
8 years, 9 months ago

Reviewers:
jam

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

npapi plugins: Make sure WebPlugin has no key functions on mac. See http://gcc.gnu.org/onlinedocs/gcc/Vague-Linkage.html BUG=90078 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127426

Patch Set 2 : better #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
M	webkit/plugins/npapi/webplugin.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/plugins/npapi/webplugin.cc	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	webkit/plugins/npapi/webplugin_impl.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/plugins/npapi/webplugin_impl.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

Without this, linking DRT fails with: "__ZN6webkit5npapi9WebPlugin21GetAcceleratedSurfaceEN3gfx13GpuPreferenceE", referenced from: __ZTVN12_GLOBAL__N_129WebPluginImplWithPageDelegateE in libwebkit_support.a(webkit_support.webkit_support.o) (This is the ...

8 years, 9 months ago (2012-03-17 04:49:28 UTC) #1

Nico

I changed the approach. With patch set 1, ld would complain about a missing vtable ...

8 years, 9 months ago (2012-03-17 18:00:28 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9720021/3

8 years, 9 months ago (2012-03-18 19:06:06 UTC) #4

Change committed as 127426

Expand Messages | Collapse Messages

Issue 9720021: npapi plugins: Make sure WebPlugin has no key functions on mac. (Closed)

Description

Patch Set 1 #

Patch Set 2 : better #

Messages