Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: remoting/host/log_to_server.cc

Issue 9720019: Use scoped_ptr<> to pass ownership in more places. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: - Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« remoting/host/chromoting_host_unittest.cc ('K') | « remoting/host/local_input_monitor_win.cc ('k') | remoting/host/register_support_host_request.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/log_to_server.cc
diff --git a/remoting/host/log_to_server.cc b/remoting/host/log_to_server.cc
index f75764ade6c773917a0a70641f3c988928ff36ad..47c483688a3c24c269254e66c49bc27029a0ca07 100644
--- a/remoting/host/log_to_server.cc
+++ b/remoting/host/log_to_server.cc
@@ -97,7 +97,7 @@ void LogToServer::SendPendingEntries() {
kChromotingXmlNamespace, kLogCommand)));
while (!pending_entries_.empty()) {
ServerLogEntry& entry = pending_entries_.front();
- stanza->AddElement(entry.ToStanza());
Alpha Left Google 2012/03/20 18:56:40 This old code seems to cause a crash.
Sergey Ulanov 2012/03/20 19:08:12 Not sure what you mean here. How does it cause a c
+ stanza->AddElement(entry.ToStanza().release());
pending_entries_.pop_front();
}
// Send the stanza to the server.
« remoting/host/chromoting_host_unittest.cc ('K') | « remoting/host/local_input_monitor_win.cc ('k') | remoting/host/register_support_host_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698