Aura: Add non-browser windows into the list of "Alt + Tab" cycle list.

ash/wm/activation_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_ACTIVATION_CONTROLLER_H_
 #define ASH_WM_ACTIVATION_CONTROLLER_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
@@ skipping 16 matching lines @@
  public:
   ActivationController();
   virtual ~ActivationController();
 
   // Returns true if |window| exists within a container that supports
   // activation. |event| is the revent responsible for initiating the change, or
   // NULL if there is no event.
   static aura::Window* GetActivatableWindow(aura::Window* window,
                                             const aura::Event* event);
 
+  // Determines if the given window itself can be activated or not. Returns

[sky, 2012/03/27 14:59:58]

How about:
Returns true if |window| can be activated, false otherwise. If |window| has a
modal child it can not be activated.

[yoshiki, 2012/03/28 15:08:41]

Done. Thanks, I've used it. And the comment has been moved to
activation_client.h.

+  // true if the window itself can be activated. (If it has a modal child
+  // window, it cannot be activated, because the focus is propagated) Otherwise,
+  // return false.
+  static bool CanActivateWindowItself(aura::Window* window);

[sky, 2012/03/27 14:59:58]

Just CanActivateWindow, and this should be a method on ActivationClient.

[yoshiki, 2012/03/28 15:08:41]

Done.

+
   // Overridden from aura::client::ActivationClient:
   virtual void ActivateWindow(aura::Window* window) OVERRIDE;
   virtual void DeactivateWindow(aura::Window* window) OVERRIDE;
   virtual aura::Window* GetActiveWindow() OVERRIDE;
   virtual bool OnWillFocusWindow(aura::Window* window,
                                  const aura::Event* event) OVERRIDE;
 
   // Overridden from aura::WindowObserver:
   virtual void OnWindowVisibilityChanged(aura::Window* window,
                                          bool visible) OVERRIDE;
@@ skipping 27 matching lines @@
   // change notifications causing activation.
   bool updating_activation_;
 
   DISALLOW_COPY_AND_ASSIGN(ActivationController);
 };
 
 }  // namespace internal
 }  // namespace ash
 
 #endif  // ASH_WM_ACTIVATION_CONTROLLER_H_