Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2507)

Unified Diff: build/common.gypi

Issue 9718030: Including ATL 7.1 makes the linker to generate almost eight hundred LNK4254 and LNK4078 warnings. T… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CR feedback Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index d9ac79a895a91f24d00a5d84fd9c40ee881ca283..9fff110700c8962c1bc37bfa1bd8d9478188d139 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2785,12 +2785,21 @@
'winmm.lib',
'shlwapi.lib',
],
+
'conditions': [
['msvs_express', {
# Explicitly required when using the ATL with express
'AdditionalDependencies': [
'atlthunk.lib',
],
+
+ # ATL 8.0 included in WDK 7.1 makes the linker to generate
+ # almost eight hundred LNK4254 and LNK4078 warnings:
+ # - warning LNK4254: section 'ATL' (50000040) merged into
+ # '.rdata' (40000040) with different attributes
+ # - warning LNK4078: multiple 'ATL' sections found with
+ # different attributes
+ 'AdditionalOptions': ['/ignore:4254', '/ignore:4078'],
}],
['MSVS_VERSION=="2005e"', {
# Non-express versions link automatically to these
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698