Issue 9718013: Merge FilterStatusCB into PipelineStatusCB.

Issue 9718013: Merge FilterStatusCB into PipelineStatusCB. (Closed)

Created:
8 years, 9 months ago by xhwang

Modified:
8 years, 9 months ago

Reviewers:
Ami GONE FROM CHROMIUM

CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Merge FilterStatusCB into PipelineStatusCB. BUG=none TEST=media_unittest,content_unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127397

Patch Set 2 : Keep ResetAndRunCB in filters.h. #

Total comments: 6

Patch Set 4 : Rebase #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -73 lines)			Patch
M	content/renderer/media/audio_renderer_impl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/media/audio_renderer_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/media/capture_video_decoder.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/renderer/media/capture_video_decoder.cc	View	1 2	2 chunks	+4 lines, -3 lines	0 comments	Download
M	content/renderer/media/rtc_video_decoder.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/media/rtc_video_decoder.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/base/composite_filter.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	media/base/composite_filter.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/composite_filter_unittest.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	media/base/filters.h	View	1	2 chunks	+2 lines, -7 lines	0 comments	Download
M	media/base/filters.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	media/base/mock_filters.h	View	1 2	7 chunks	+9 lines, -10 lines	0 comments	Download
M	media/base/mock_filters.cc	View		2 chunks	+6 lines, -11 lines	0 comments	Download
M	media/base/pipeline.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	media/base/pipeline_unittest.cc	View		6 chunks	+9 lines, -9 lines	0 comments	Download
M	media/filters/audio_renderer_base.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/filters/audio_renderer_base.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/audio_renderer_base_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/ffmpeg_video_decoder.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/ffmpeg_video_decoder.cc	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	media/filters/gpu_video_decoder.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/gpu_video_decoder.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	media/filters/video_renderer_base.h	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	media/filters/video_renderer_base.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

xhwang

Hello fischman, Mostly just renaming. The only non-renaming changes are in filters.h and mock_filters.h. Please ...

8 years, 9 months ago (2012-03-17 16:41:26 UTC) #1

Ami GONE FROM CHROMIUM

LGTM % nits. http://codereview.chromium.org/9718013/diff/3002/content/renderer/media/capture_video_decoder.cc File content/renderer/media/capture_video_decoder.cc (right): http://codereview.chromium.org/9718013/diff/3002/content/renderer/media/capture_video_decoder.cc#newcode192 content/renderer/media/capture_video_decoder.cc:192: const media::PipelineStatusCB& status_cb) { s/status_// to ...

8 years, 9 months ago (2012-03-17 17:27:11 UTC) #2

xhwang

http://codereview.chromium.org/9718013/diff/3002/content/renderer/media/capture_video_decoder.cc File content/renderer/media/capture_video_decoder.cc (right): http://codereview.chromium.org/9718013/diff/3002/content/renderer/media/capture_video_decoder.cc#newcode192 content/renderer/media/capture_video_decoder.cc:192: const media::PipelineStatusCB& status_cb) { On 2012/03/17 17:27:11, Ami Fischman ...

8 years, 9 months ago (2012-03-17 19:20:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/9718013/6002

8 years, 9 months ago (2012-03-18 02:17:16 UTC) #4

Change committed as 127397

Expand Messages | Collapse Messages