media/base/filters.cc - Issue 9717021: Make Callback::Reset() return a copy to support use-cases where Run() ends up modifying |*this|.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/filters.cc

Issue 9717021: Make Callback::Reset() return a copy to support use-cases where Run() ends up modifying |*this|. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: no base:: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/filters.cc

diff --git a/media/base/filters.cc b/media/base/filters.cc

index 11e7cba0ddf0c17f7c43e57785a4d921a478a323..910f1e7b8a437b2acd5c11ee438f41bcbf8892c1 100644

--- a/media/base/filters.cc

+++ b/media/base/filters.cc

@@ -8,20 +8,6 @@

namespace media {

-void ResetAndRunCB(PipelineStatusCB* cb, PipelineStatus status) {

- DCHECK(!cb->is_null());

- PipelineStatusCB tmp_cb(*cb);

- cb->Reset();

- tmp_cb.Run(status);

-void ResetAndRunCB(base::Closure* cb) {

- DCHECK(!cb->is_null());

- base::Closure tmp_cb(*cb);

- cb->Reset();

- tmp_cb.Run();

Filter::Filter() : host_(NULL) {}

Filter::~Filter() {}

« no previous file with comments | « media/base/filters.h ('k') | media/filters/audio_renderer_base.cc » ('j') | no next file with comments »