Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Unified Diff: media/base/composite_filter_unittest.cc

Issue 9717021: Make Callback::Reset() return a copy to support use-cases where Run() ends up modifying |*this|. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: no base:: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/composite_filter.cc ('k') | media/base/filters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/composite_filter_unittest.cc
diff --git a/media/base/composite_filter_unittest.cc b/media/base/composite_filter_unittest.cc
index 30f6d27aabf50ec68b55c96c95e06feb19a5038b..49421fefa95c647fc3955ab1622d11ac37caa037 100644
--- a/media/base/composite_filter_unittest.cc
+++ b/media/base/composite_filter_unittest.cc
@@ -3,6 +3,7 @@
// found in the LICENSE file.
#include "base/bind.h"
+#include "base/callback_helpers.h"
#include "base/message_loop.h"
#include "media/base/composite_filter.h"
#include "media/base/mock_callback.h"
@@ -336,7 +337,7 @@ void CompositeFilterTest::RunFilter1Callback() {
EXPECT_TRUE(HasFilter1Callback());
if (!filter_1_status_cb_.is_null()) {
- ResetAndRunCB(&filter_1_status_cb_, filter_1_status_);
+ base::ResetAndReturn(&filter_1_status_cb_).Run(filter_1_status_);
filter_1_status_ = PIPELINE_OK;
return;
}
@@ -356,7 +357,7 @@ void CompositeFilterTest::RunFilter2Callback() {
EXPECT_TRUE(HasFilter2Callback());
if (!filter_2_status_cb_.is_null()) {
- ResetAndRunCB(&filter_2_status_cb_, filter_2_status_);
+ base::ResetAndReturn(&filter_2_status_cb_).Run(filter_2_status_);
filter_2_status_ = PIPELINE_OK;
return;
}
« no previous file with comments | « media/base/composite_filter.cc ('k') | media/base/filters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698