content/renderer/media/capture_video_decoder.cc - Issue 9717021: Make Callback::Reset() return a copy to support use-cases where Run() ends up modifying |*this|.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/capture_video_decoder.cc

Issue 9717021: Make Callback::Reset() return a copy to support use-cases where Run() ends up modifying |*this|. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: no base:: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/capture_video_decoder.cc

diff --git a/content/renderer/media/capture_video_decoder.cc b/content/renderer/media/capture_video_decoder.cc

index 19371155a9e9e3d23bab57c7864469e401ee2442..97626e61782412fe1d6e1b1464a0b7785f4c43e2 100644

--- a/content/renderer/media/capture_video_decoder.cc

+++ b/content/renderer/media/capture_video_decoder.cc

@@ -5,6 +5,7 @@

#include "content/renderer/media/capture_video_decoder.h"

#include "base/bind.h"

+#include "base/callback_helpers.h"

#include "content/renderer/media/video_capture_impl_manager.h"

#include "media/base/filter_host.h"

#include "media/base/limits.h"

@@ -202,7 +203,7 @@ void CaptureVideoDecoder::OnStoppedOnDecoderThread(

DVLOG(1) << "OnStoppedOnDecoderThread";

DCHECK(message_loop_proxy_->BelongsToCurrentThread());

if (!pending_stop_cb_.is_null())

- media::ResetAndRunCB(&pending_stop_cb_);

+ base::ResetAndReturn(&pending_stop_cb_).Run();

vc_manager_->RemoveDevice(video_stream_id_, this);

}

« no previous file with comments | « base/callback_unittest.cc ('k') | media/base/composite_filter.cc » ('j') | no next file with comments »