Make Callback::Reset() return a copy to support use-cases where Run() ends up modifying |*this|.

base/callback_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/bind.h"
 #include "base/callback.h"
+#include "base/callback_helpers.h"
 #include "base/callback_internal.h"
 #include "base/memory/scoped_ptr.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
 
 namespace {
 
-class HelperObject {
- public:
-  HelperObject() : next_number_(0) { }
-  int GetNextNumber() { return ++next_number_; }
-  void GetNextNumberArg(int* number) { *number = GetNextNumber(); }
-
- private:
-  int next_number_;
-};
-
 struct FakeInvoker {
   typedef void(RunType)(internal::BindStateBase*);
   static void Run(internal::BindStateBase*) {
   }
 };
+
 }  // namespace
 
 namespace internal {
 template <typename Runnable, typename RunType, typename BoundArgsType>
 struct BindState;
 
 // White-box testpoints to inject into a Callback<> object for checking
 // comparators and emptiness APIs.  Use a BindState that is specialized
 // based on a type we declared in the anonymous namespace above to remove any
 // chance of colliding with another instantiation and breaking the
@@ skipping 84 matching lines @@
   // Resetting should bring us back to empty.
   ASSERT_FALSE(callback_a_.is_null());
   ASSERT_FALSE(callback_a_.Equals(null_callback_));
 
   callback_a_.Reset();
 
   EXPECT_TRUE(callback_a_.is_null());
   EXPECT_TRUE(callback_a_.Equals(null_callback_));
 }
 
+struct TestForReentrancy {
+  TestForReentrancy()
+      : cb_already_run(false),
+        cb(base::Bind(&TestForReentrancy::AssertCBIsNull,

[akalin, 2012/03/23 18:42:07]

no base::

[Ami GONE FROM CHROMIUM, 2012/03/24 17:43:35]

Done.

+                      base::Unretained(this))) {

[akalin, 2012/03/23 18:42:07]

no base::

[Ami GONE FROM CHROMIUM, 2012/03/24 17:43:35]

Done.

+  }
+  void AssertCBIsNull() {
+    ASSERT_TRUE(cb.is_null());
+    cb_already_run = true;
+  }
+  bool cb_already_run;
+  Closure cb;
+};
+
+TEST_F(CallbackTest, ResetAndReturn) {
+  TestForReentrancy tfr;
+  ASSERT_FALSE(tfr.cb.is_null());
+  ASSERT_FALSE(tfr.cb_already_run);
+  base::ResetAndReturn(&tfr.cb).Run();

[akalin, 2012/03/23 18:42:07]

no base::

[Ami GONE FROM CHROMIUM, 2012/03/24 17:43:35]

Done.

+  ASSERT_TRUE(tfr.cb.is_null());
+  ASSERT_TRUE(tfr.cb_already_run);
+}
+
 }  // namespace
 }  // namespace base