Expose the chrome.windows.* API to platform apps.

Expose the chrome.windows.* API to platform apps.

BUG=113412
R=jstritar@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128156

[jstritar, 2012-03-16 23:40:52]

I think Aaron's changes to the permission restrictions landed right before you
uploaded this, so you'll need to update that json file instead of the permission
set now.

[Aaron Boodman, 2012-03-16 23:57:56]

=P

On Fri, Mar 16, 2012 at 4:40 PM,  <jstritar@chromium.org> wrote:
> I think Aaron's changes to the permission restrictions landed right before
> you
> uploaded this, so you'll need to update that json file instead of the
> permission
> set now.
>
> http://codereview.chromium.org/9717011/

[jstritar, 2012-03-19 19:08:52]

This will scope the windows correctly once we're launching apps with the correct
profile and process model?

http://codereview.chromium.org/9717011/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_tabs_module.cc (right):

http://codereview.chromium.org/9717011/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_tabs_module.cc:594:
ShellWindow::Create(window_profile, GetExtension(), window_url);
|window_profile| can be an incognito profile, if set in the create options. Is
this okay for shell windows?

[jstritar, 2012-03-20 16:07:25]

Oh yeah, this LGTM once you update the restrictions format.

[Mihai Parparita -not on Chrome, 2012-03-21 22:41:09]

On 2012/03/20 16:07:25, jstritar wrote:
> Oh yeah, this LGTM once you update the restrictions format.

Switched to _permission_features.json.

[jstritar, 2012-03-21 22:45:05]

LGTM

[commit-bot: I haz the power, 2012-03-22 01:42:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mihaip@chromium.org/9717011/26001

[commit-bot: I haz the power, 2012-03-22 03:21:13]

Change committed as 128156