net/spdy/spdy_frame_reader.cc - Issue 9716020: Add base::HostToNetXX() & NetToHostXX(), and use them to replace htonX() & ntohX() in Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_frame_reader.cc

Issue 9716020: Add base::HostToNetXX() & NetToHostXX(), and use them to replace htonX() & ntohX() in Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Switch a few remaining call-sites. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_frame_reader.cc

diff --git a/net/spdy/spdy_frame_reader.cc b/net/spdy/spdy_frame_reader.cc

index 183bae909cadcaefaf7485940d41eb22adef10cd..ce56cc6e3d62cba06d98d73462ec6cd1f5674207 100644

--- a/net/spdy/spdy_frame_reader.cc

+++ b/net/spdy/spdy_frame_reader.cc

@@ -23,7 +23,7 @@ bool SpdyFrameReader::ReadUInt16(uint16* result) {

}

// Read into result.

- *result = ntohs(*(reinterpret_cast<const uint16*>(data_ + ofs_)));

+ *result = base::NetToHost16(*(reinterpret_cast<const uint16*>(data_ + ofs_)));

// Iterate.

ofs_ += 2;

@@ -39,7 +39,7 @@ bool SpdyFrameReader::ReadUInt32(uint32* result) {

}

// Read into result.

- *result = ntohl(*(reinterpret_cast<const uint32*>(data_ + ofs_)));

+ *result = base::NetToHost32(*(reinterpret_cast<const uint32*>(data_ + ofs_)));

// Iterate.

ofs_ += 4;

« no previous file with comments | « net/spdy/spdy_frame_builder.h ('k') | net/spdy/spdy_frame_reader_test.cc » ('j') | sandbox/sandbox_poc/pocdll/network.cc » ('J')