net/socket/socks_client_socket.cc - Issue 9716020: Add base::HostToNetXX() & NetToHostXX(), and use them to replace htonX() & ntohX() in Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/socks_client_socket.cc

Issue 9716020: Add base::HostToNetXX() & NetToHostXX(), and use them to replace htonX() & ntohX() in Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Switch a few remaining call-sites. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/socks_client_socket.cc

diff --git a/net/socket/socks_client_socket.cc b/net/socket/socks_client_socket.cc

index 4c368c11e70686e361f3b28428fc4c6adc3d54fd..7da0601f211a473ce7c809f49dbf19ab675a826c 100644

--- a/net/socket/socks_client_socket.cc

+++ b/net/socket/socks_client_socket.cc

@@ -7,6 +7,7 @@

#include "base/basictypes.h"

#include "base/bind.h"

#include "base/compiler_specific.h"

+#include "base/sys_byteorder.h"

#include "net/base/io_buffer.h"

#include "net/base/net_log.h"

#include "net/base/net_util.h"

@@ -297,7 +298,7 @@ const std::string SOCKSClientSocket::BuildHandshakeWriteBuffer() const {

SOCKS4ServerRequest request;

request.version = kSOCKSVersion4;

request.command = kSOCKSStreamRequest;

- request.nw_port = htons(host_request_info_.port());

+ request.nw_port = base::HostToNet16(host_request_info_.port());

const struct addrinfo* ai = addresses_.head();

DCHECK(ai);

« no previous file with comments | « net/socket/socks5_client_socket_unittest.cc ('k') | net/socket/web_socket_server_socket.cc » ('j') | sandbox/sandbox_poc/pocdll/network.cc » ('J')