Add base::HostToNetXX() & NetToHostXX(), and use them to replace htonX() & ntohX() in Chrome.

sandbox/sandbox_poc/pocdll/network.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sandbox/sandbox_poc/pocdll/exports.h"
 #include "sandbox/sandbox_poc/pocdll/utils.h"
 
 // This file contains the tests used to verify the security of the network.
 
 void POCDLL_API TestNetworkListen(HANDLE log) {
@@ skipping 17 matching lines @@
            ::WSAGetLastError());
     ::WSACleanup();
     return;
   }
 
   // The sockaddr_in structure specifies the address family,
   // IP address, and port for the socket that is being bound.
   sockaddr_in service;
   service.sin_family = AF_INET;
   service.sin_addr.s_addr = inet_addr("127.0.0.1");
-  service.sin_port = htons(88);
+  service.sin_port = base::HostToNet16(88);

[rvargas (doing something else), 2012/03/21 18:47:41]

I'm on the fence about this particular change. POC basically does not depend on
base, and it is used to showcase the sandbox functionality (in other words it is
not really used for anything on a regular Chrome build).

So in a way, this is not needed and it may mean more work in the future. Now,
philosophically, given that the point of the change is to double-fix an issue
with the sandbox access, it may be better not to touch a sandbox demo.

[Wez, 2012/03/21 20:09:03]

Done.

 
   if (bind(listen_socket, reinterpret_cast<SOCKADDR*>(&service),
            sizeof(service)) == SOCKET_ERROR) {
     fprintf(output, "[BLOCKED] Bind socket on port 88. Error %ld\r\n",
             ::WSAGetLastError());
     closesocket(listen_socket);
     ::WSACleanup();
     return;
   }
 
   // Listen for incoming connection requests
   // on the created socket
   if (listen(listen_socket, SOMAXCONN) == SOCKET_ERROR) {
     fprintf(output, "[BLOCKED] Listen socket on port 88. Error %ld\r\n",
             ::WSAGetLastError());
 
   } else {
     fprintf(output, "[GRANTED] Listen socket on port 88.\r\n",
             ::WSAGetLastError());
   }
 
   ::WSACleanup();
   return;
 #else  // DONT_WANT_INTERCEPTIONS_JUST_WANT_NETWORK
   // Just print out that this test is not running.
   fprintf(output, "[ERROR] No network tests.\r\n");
 #endif  // DONT_WANT_INTERCEPTIONS_JUST_WANT_NETWORK
 }