Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 9716017: It's OS_MACOSX, not OS_MAC. (Closed)

Created:
8 years, 9 months ago by Nico
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

It's OS_MACOSX, not OS_MAC. Introduced here: http://codereview.chromium.org/9570012/ I codesearched for "\bOS_MAC\b" to make sure this is the only place where we get this wrong. BUG=90078 TEST=Add "-all_load" to linker command lines. __Z24ShowOneClickSigninDialogP7ProfileRKSsS2_S2_ doesn't show up in the list of undefined symbols. TBR=pkasting Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/media_stream_infobar_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Nico
(looks like macorteau / yujie.mao aren't full committers yet, so I picked you randomly)
8 years, 9 months ago (2012-03-17 20:01:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9716017/1
8 years, 9 months ago (2012-03-17 20:02:10 UTC) #2
Peter Kasting
LGTM
8 years, 9 months ago (2012-03-17 20:46:21 UTC) #3
commit-bot: I haz the power
Try job failure for 9716017-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-17 22:45:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9716017/1
8 years, 9 months ago (2012-03-17 22:55:03 UTC) #5
commit-bot: I haz the power
Try job failure for 9716017-1 (retry) on win_rel for . It's a second try, previously, ...
8 years, 9 months ago (2012-03-18 00:17:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9716017/1
8 years, 9 months ago (2012-03-18 00:28:41 UTC) #7
commit-bot: I haz the power
Change committed as 127389
8 years, 9 months ago (2012-03-18 01:52:08 UTC) #8
Peter Mayo
Any chance you can do the same check for OS_CHROME rather than OS_CHROMEOS? (http://codereview.chromium.org/9582011/ took ...
8 years, 9 months ago (2012-03-18 02:06:30 UTC) #9
Nico
8 years, 9 months ago (2012-03-18 02:49:16 UTC) #10
On 2012/03/18 02:06:30, Peter Mayo wrote:
> Any chance you can do the same check for OS_CHROME rather than OS_CHROMEOS?
>   (http://codereview.chromium.org/9582011/ took far too long to diagnose)
> 
> Just in case your search-FU is greater than mine.

http://code.google.com/p/chromium/source/search?q=%5CbOS_CHROME%5Cb&origq=%5C...
<- looks good as far as I can tell

Powered by Google App Engine
This is Rietveld 408576698