Properly recognize closures when setting breakpoints

runtime/vm/debugger.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/debugger.h"
 
 #include "vm/code_index_table.h"
 #include "vm/code_generator.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
@@ skipping 55 matching lines @@
   // Compute line number lazily since it causes scanning of the script.
   if (line_number_ < 0) {
     const Script& script = Script::Handle(SourceCode());
     intptr_t ignore_column;
     script.GetTokenLocation(token_index_, &line_number_, &ignore_column);
   }
   return line_number_;
 }
 
 
+void SourceBreakpoint::set_function(const Function& func) {
+  function_ = func.raw();
+}
+
+
 void SourceBreakpoint::VisitObjectPointers(ObjectPointerVisitor* visitor) {
   visitor->VisitPointer(reinterpret_cast<RawObject**>(&function_));
 }
 
 
 
 void CodeBreakpoint::VisitObjectPointers(ObjectPointerVisitor* visitor) {
   visitor->VisitPointer(reinterpret_cast<RawObject**>(&function_));
 }
 
@@ skipping 843 matching lines @@
   SetBreakpointHandler(DefaultBreakpointHandler);
 }
 
 
 void Debugger::NotifyCompilation(const Function& func) {
   if (src_breakpoints_ == NULL) {
     // Return with minimal overhead if there are no breakpoints.
     return;
   }
   Function& lookup_function = Function::Handle(func.raw());
-  if (func.IsClosureFunction()) {
+  if (func.IsImplicitClosureFunction()) {

[regis, 2012/03/16 22:04:01]

I do not understand why you changed this test. The comment below applies to all
closures, not just implicit ones.

[hausner, 2012/03/16 22:20:58]

Updated the comment.

     // If the newly compiled function is a closure, we need to use
     // the closure's parent function to see whether there are any
     // breakpoints.
     lookup_function = func.parent_function();

[regis, 2012/03/16 22:04:01]

ASSERT(!lookup_function.IsNull());?

[hausner, 2012/03/16 22:20:58]

Done.

   }
   SourceBreakpoint* bpt = src_breakpoints_;
   while (bpt != NULL) {
     if (lookup_function.raw() == bpt->function()) {
-      if (verbose) {
-        OS::Print("Enable latent breakpoint for function '%s'\n",
-                  String::Handle(lookup_function.name()).ToCString());
-      }
-      // Set breakpoint in newly compiled code of function func.
-      CodeBreakpoint* cbpt = MakeCodeBreakpoint(func, bpt->token_index());
-      if (cbpt != NULL) {
-        cbpt->set_src_bpt(bpt);
+       // Check if the breakpoint is inside a closure or local function

[regis, 2012/03/16 22:04:01]

Indentation

[hausner, 2012/03/16 22:20:58]

Done.

+      // within the newly compiled function.
+      Class& owner = Class::Handle(lookup_function.owner());
+      Function& closure =
+          Function::Handle(owner.LookupClosureFunction(bpt->token_index()));
+      if (!closure.IsNull() && (closure.raw() != lookup_function.raw())) {
+        if (verbose) {
+          OS::Print("Resetting pending breakpoint to function %s\n",
+                    String::Handle(closure.name()).ToCString());
+        }
+        bpt->set_function(closure);
+      } else {
+        if (verbose) {
+          OS::Print("Enable pending breakpoint for function '%s'\n",
+                    String::Handle(lookup_function.name()).ToCString());
+        }
+        // Set breakpoint in newly compiled code of function func.
+        CodeBreakpoint* cbpt = MakeCodeBreakpoint(func, bpt->token_index());
+        if (cbpt != NULL) {
+          cbpt->set_src_bpt(bpt);
+        }
       }
       bpt->Enable();  // Enables the code breakpoint as well.
     }
     bpt = bpt->next();
   }
 }
 
 
 CodeBreakpoint* Debugger::GetCodeBreakpoint(uword breakpoint_address) {
   CodeBreakpoint* bpt = code_breakpoints_;
@@ skipping 84 matching lines @@
 }
 
 
 void Debugger::RegisterCodeBreakpoint(CodeBreakpoint* bpt) {
   ASSERT(bpt->next() == NULL);
   bpt->set_next(code_breakpoints_);
   code_breakpoints_ = bpt;
 }
 
 }  // namespace dart