Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9712001: Check explicitly for version 1.0 PPB_File* interfaces in pp::File* wrappers. (Closed)

Created:
8 years, 9 months ago by Wez
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Check explicitly for version 1.0 PPB_File* interfaces in pp::File* wrappers. BUG=107398 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130042

Patch Set 1 #

Patch Set 2 : Fix missed interface_name definitions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -48 lines) Patch
M ppapi/cpp/file_io.cc View 5 chunks +20 lines, -20 lines 0 comments Download
M ppapi/cpp/file_ref.cc View 1 5 chunks +24 lines, -22 lines 0 comments Download
M ppapi/cpp/file_system.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Wez
PTAL
8 years, 9 months ago (2012-03-16 04:21:11 UTC) #1
Wez
On 2012/03/16 04:21:11, Wez wrote: > PTAL Ping!
8 years, 9 months ago (2012-03-21 17:10:43 UTC) #2
Wez
ETIMEDOUT from sanga@ - could you take a look, dmichael@?
8 years, 9 months ago (2012-03-28 20:41:56 UTC) #3
dmichael (off chromium)
lgtm
8 years, 9 months ago (2012-03-28 20:47:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/9712001/3001
8 years, 8 months ago (2012-03-29 21:24:59 UTC) #5
commit-bot: I haz the power
Try job failure for 9712001-3001 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-03-29 22:26:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/9712001/3001
8 years, 8 months ago (2012-03-30 00:43:39 UTC) #7
commit-bot: I haz the power
Try job failure for 9712001-3001 (retry) (retry) on win_rel for step "browser_tests". It's a second ...
8 years, 8 months ago (2012-03-30 05:18:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/9712001/3001
8 years, 8 months ago (2012-03-30 19:23:55 UTC) #9
commit-bot: I haz the power
Try job failure for 9712001-3001 (retry) on win_rel for step "browser_tests" (clobber build). It's a ...
8 years, 8 months ago (2012-03-30 21:29:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/9712001/3001
8 years, 8 months ago (2012-03-30 22:43:23 UTC) #11
commit-bot: I haz the power
8 years, 8 months ago (2012-03-31 04:24:23 UTC) #12 
Change committed as 130042

Powered by Google App Engine
This is Rietveld 408576698