Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 9706058: Implement dtrace log parsing for MacOSX. (Closed)

Created:
8 years, 9 months ago by M-A Ruel
Modified:
8 years, 9 months ago
CC:
chromium-reviews, pam+watch_chromium.org, csharp
Visibility:
Public.

Description

Implement dtrace log parsing for MacOSX. Rename strace_inputs.py to trace_inputs.py since it's now using both strace and dtrace, depending on the platform. R=rogerta@chromium.org BUG=98636 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127100

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+392 lines, -163 lines) Patch
M testing/test_env.py View 1 chunk +5 lines, -1 line 0 comments Download
D tools/isolate/strace_inputs.py View 1 chunk +0 lines, -162 lines 0 comments Download
A tools/isolate/trace_child_process.py View 1 chunk +33 lines, -0 lines 0 comments Download
A tools/isolate/trace_inputs.py View 1 chunk +354 lines, -0 lines 4 comments Download

Messages

Total messages: 7 (0 generated)
M-A Ruel
Still works on both mac and linux. Helps a lot in finding the current dependencies. ...
8 years, 9 months ago (2012-03-15 15:16:22 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm A couple of question about dtrace code, but likely my misunderstanding. http://codereview.chromium.org/9706058/diff/1/tools/isolate/trace_inputs.py File tools/isolate/trace_inputs.py ...
8 years, 9 months ago (2012-03-15 18:07:16 UTC) #2
M-A Ruel
http://codereview.chromium.org/9706058/diff/1/tools/isolate/trace_inputs.py File tools/isolate/trace_inputs.py (right): http://codereview.chromium.org/9706058/diff/1/tools/isolate/trace_inputs.py#newcode123 tools/isolate/trace_inputs.py:123: dtrace:::BEGIN { On 2012/03/15 18:07:16, Roger Tawa wrote: > ...
8 years, 9 months ago (2012-03-15 18:09:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9706058/1
8 years, 9 months ago (2012-03-15 18:23:13 UTC) #4
commit-bot: I haz the power
Try job failure for 9706058-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-15 22:44:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9706058/1
8 years, 9 months ago (2012-03-16 00:01:58 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-16 04:18:27 UTC) #7
Change committed as 127100

Powered by Google App Engine
This is Rietveld 408576698